fix: review

Signed-off-by: mario ma <mario.ma.node@gmail.com>
2025-04-08 10:22:13 +08:00
parent 0255fe402f
commit 50f0e841b2
5 changed files with 9 additions and 3 deletions
@@ -114,7 +114,7 @@ export const UserSettingsFeatureFlags = () => {
              ...(filterInput.length && {
                endAdornment: (
                  <IconButton
-                    aria-label="Clear filter"
+                    aria-label={t('featureFlags.clearFilter')}
                    onClick={clearFilterInput}
                    edge="end"
                  >
@@ -51,7 +51,7 @@ export const UserSettingsMenu = () => {
    <>
      <IconButton
        data-testid="user-settings-menu"
-        aria-label="more"
+        aria-label={t('signOutMenu.moreIconTitle')}
        onClick={handleOpen}
      >
        <MoreVertIcon />
@@ -49,7 +49,7 @@ export const UserSettingsPinToggle = () => {
            checked={isPinned}
            onChange={() => toggleSidebarPinState()}
            name="pin"
-            inputProps={{ 'aria-label': 'Pin Sidebar Switch' }}
+            inputProps={{ 'aria-label': t('pinToggle.ariaLabelTitle') }}
          />
        </Tooltip>
      </ListItemSecondaryAction>
@@ -38,6 +38,7 @@ export const userSettingsTranslationRef = createTranslationRef({
    },
    signOutMenu: {
      title: 'Sign Out',
+      moreIconTitle: 'More',
    },
    pinToggle: {
      title: 'Pin Sidebar',
@@ -46,6 +47,7 @@ export const userSettingsTranslationRef = createTranslationRef({
        unpin: 'Unpin Sidebar',
        pin: 'Pin Sidebar',
      },
+      ariaLabelTitle: 'Pin Sidebar Switch',
    },
    identityCard: {
      title: 'Backstage Identity',
@@ -101,6 +103,7 @@ export const userSettingsTranslationRef = createTranslationRef({
        },
      },
      filterTitle: 'Filter',
+      clearFilter: 'Clear filter',
      flagItem: {
        title: {
          disable: 'Disable',