fix: review

Signed-off-by: mario ma <mario.ma.node@gmail.com>

plugins/user-settings/report-alpha.api.md

@@ -109,6 +109,7 @@ export const userSettingsTranslationRef: TranslationRef<
     readonly 'featureFlags.title': 'Feature Flags';
     readonly 'featureFlags.description': 'Please refresh the page when toggling feature flags';
     readonly 'featureFlags.filterTitle': 'Filter';
+    readonly 'featureFlags.clearFilter': 'Clear filter';
     readonly 'featureFlags.emptyFlags.title': 'No Feature Flags';
     readonly 'featureFlags.emptyFlags.action.title': 'An example for how to add a feature flag is highlighted below:';
     readonly 'featureFlags.emptyFlags.action.readMoreButtonTitle': 'Read More';
@@ -128,8 +129,10 @@ export const userSettingsTranslationRef: TranslationRef<
     readonly 'themeToggle.names.light': 'Light';
     readonly 'themeToggle.selectAuto': 'Select Auto Theme';
     readonly 'signOutMenu.title': 'Sign Out';
+    readonly 'signOutMenu.moreIconTitle': 'More';
     readonly 'pinToggle.title': 'Pin Sidebar';
     readonly 'pinToggle.description': 'Prevent the sidebar from collapsing';
+    readonly 'pinToggle.ariaLabelTitle': 'Pin Sidebar Switch';
     readonly 'pinToggle.switchTitles.unpin': 'Unpin Sidebar';
     readonly 'pinToggle.switchTitles.pin': 'Pin Sidebar';
     readonly 'identityCard.title': 'Backstage Identity';

plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx

@@ -114,7 +114,7 @@ export const UserSettingsFeatureFlags = () => {
               ...(filterInput.length && {
                 endAdornment: (
                   <IconButton
-                    aria-label="Clear filter"
+                    aria-label={t('featureFlags.clearFilter')}
                     onClick={clearFilterInput}
                     edge="end"
                   >

plugins/user-settings/src/components/General/UserSettingsMenu.tsx

@@ -51,7 +51,7 @@ export const UserSettingsMenu = () => {
     <>
       <IconButton
         data-testid="user-settings-menu"
-        aria-label="more"
+        aria-label={t('signOutMenu.moreIconTitle')}
         onClick={handleOpen}
       >
         <MoreVertIcon />

plugins/user-settings/src/components/General/UserSettingsPinToggle.tsx

@@ -49,7 +49,7 @@ export const UserSettingsPinToggle = () => {
             checked={isPinned}
             onChange={() => toggleSidebarPinState()}
             name="pin"
-            inputProps={{ 'aria-label': 'Pin Sidebar Switch' }}
+            inputProps={{ 'aria-label': t('pinToggle.ariaLabelTitle') }}
           />
         </Tooltip>
       </ListItemSecondaryAction>

plugins/user-settings/src/translation.ts

@@ -38,6 +38,7 @@ export const userSettingsTranslationRef = createTranslationRef({
     },
     signOutMenu: {
       title: 'Sign Out',
+      moreIconTitle: 'More',
     },
     pinToggle: {
       title: 'Pin Sidebar',
@@ -46,6 +47,7 @@ export const userSettingsTranslationRef = createTranslationRef({
         unpin: 'Unpin Sidebar',
         pin: 'Pin Sidebar',
       },
+      ariaLabelTitle: 'Pin Sidebar Switch',
     },
     identityCard: {
       title: 'Backstage Identity',
@@ -101,6 +103,7 @@ export const userSettingsTranslationRef = createTranslationRef({
         },
       },
       filterTitle: 'Filter',
+      clearFilter: 'Clear filter',
       flagItem: {
         title: {
           disable: 'Disable',