paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 36 Packages Projects Releases Wiki Activity

Merge pull request #33378 from backstage/fix/table-complete-mode-loading

Browse Source 
Fix Table loading skeleton not showing for complete mode with getData
This commit is contained in:
Charles de Dreuille
2026-03-17 07:18:44 +00:00
committed by GitHub
parent 57726bf1c2 9314ff5162
commit 5096efc276
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/Table/hooks/useCompletePagination.ts
+6 -3
View File
@@ -43,7 +43,7 @@ export function useCompletePagination<T extends TableItem, TFilter>(
const getData = useStableCallback(getDataProp);
const { sort, filter, search } = query;
const [items, setItems] = useState<T[]>([]);
const [items, setItems] = useState<T[] | undefined>(undefined);
const [isLoading, setIsLoading] = useState(!data);
const [error, setError] = useState<Error | undefined>(undefined);
const [loadCount, setLoadCount] = useState(0);
@@ -95,6 +95,9 @@ export function useCompletePagination<T extends TableItem, TFilter>(
// Process data client-side (filter, search, sort)
const processedData = useMemo(() => {
if (!resolvedItems) {
return undefined;
}
let result = [...resolvedItems];
if (filter !== undefined && filterFn) {
result = filterFn(result, filter);
@@ -108,11 +111,11 @@ export function useCompletePagination<T extends TableItem, TFilter>(
return result;
}, [resolvedItems, sort, filter, search, filterFn, searchFn, sortFn]);
const totalCount = processedData.length;
const totalCount = processedData?.length ?? 0;
// Paginate the processed data
const paginatedData = useMemo(
() => processedData.slice(offset, offset + pageSize),
() => processedData?.slice(offset, offset + pageSize),
[processedData, offset, pageSize],
);