diff --git a/packages/app/src/App.tsx b/packages/app/src/App.tsx index 7e49ad5087..be9ae17286 100644 --- a/packages/app/src/App.tsx +++ b/packages/app/src/App.tsx @@ -226,7 +226,6 @@ const routes = ( - diff --git a/packages/app/src/components/scaffolder/customScaffolderLayouts.tsx b/packages/app/src/components/scaffolder/customScaffolderLayouts.tsx index 065a1ca780..71e38d76ce 100644 --- a/packages/app/src/components/scaffolder/customScaffolderLayouts.tsx +++ b/packages/app/src/components/scaffolder/customScaffolderLayouts.tsx @@ -21,7 +21,6 @@ import { } from '@backstage/plugin-scaffolder'; const ALayout: ObjectFieldTemplate = ({ properties, description }) => { - // eslint-disable-next-line no-console return (

CUSTOM LAYOUT!!!!!

@@ -35,34 +34,9 @@ const ALayout: ObjectFieldTemplate = ({ properties, description }) => { ); }; -const AnotherCustomLayout: ObjectFieldTemplate = ({ - properties, - description, -}) => { - // eslint-disable-next-line no-console - return ( -
-

ANOTHER CUSTOM LAYOUT!!!!!

-
- {properties.map(prop => ( -
{prop.content}
- ))} -
- {description} -
- ); -}; - export const CustomLayout = scaffolderPlugin.provide( createScaffolderLayout({ name: 'CustomLayout', component: ALayout, }), ); - -export const AnotherCustomlayout = scaffolderPlugin.provide( - createScaffolderLayout({ - name: 'AnotherCustomLayout', - component: AnotherCustomLayout, - }), -); diff --git a/packages/app/src/components/scaffolder/defaultPreviewTemplate.ts b/packages/app/src/components/scaffolder/defaultPreviewTemplate.ts index 53805265ed..db0725591c 100644 --- a/packages/app/src/components/scaffolder/defaultPreviewTemplate.ts +++ b/packages/app/src/components/scaffolder/defaultPreviewTemplate.ts @@ -34,7 +34,6 @@ parameters: allowedKinds: - Group - title: Choose a location - ui:ObjectFieldTemplate: 'AnotherCustomLayout' required: - repoUrl properties: diff --git a/plugins/scaffolder/src/components/MultistepJsonForm/MultistepJsonForm.tsx b/plugins/scaffolder/src/components/MultistepJsonForm/MultistepJsonForm.tsx index 6ec88777f2..bea7279c4e 100644 --- a/plugins/scaffolder/src/components/MultistepJsonForm/MultistepJsonForm.tsx +++ b/plugins/scaffolder/src/components/MultistepJsonForm/MultistepJsonForm.tsx @@ -154,7 +154,6 @@ export const MultistepJsonForm = (props: Props) => { ) : filteredStep.schema.required; } - return filteredStep; }; diff --git a/plugins/scaffolder/src/next/Router/Router.test.tsx b/plugins/scaffolder/src/next/Router/Router.test.tsx index d1c627de51..1aaca1a94b 100644 --- a/plugins/scaffolder/src/next/Router/Router.test.tsx +++ b/plugins/scaffolder/src/next/Router/Router.test.tsx @@ -22,13 +22,7 @@ import { createScaffolderFieldExtension, ScaffolderFieldExtensions, } from '../../extensions'; -import { - createScaffolderLayout, - DEFAULT_SCAFFOLDER_LAYOUT, - ScaffolderLayouts, -} from '../../layouts'; import { scaffolderPlugin } from '../../plugin'; -import { ObjectFieldTemplateProps } from '@rjsf/core'; jest.mock('../TemplateListPage', () => ({ TemplateListPage: jest.fn(() => null), @@ -87,42 +81,5 @@ describe('Router', () => { ]), ); }); - - it('should use the default layout', async () => { - await renderInTestApp(, { - routeEntries: ['/templates/default/foo'], - }); - - const mock = TemplateWizardPage as jest.Mock; - - const [{ layout }] = mock.mock.calls[0]; - - expect(layout).toEqual(DEFAULT_SCAFFOLDER_LAYOUT); - }); - - it('should extract the custom layout and pass it through', async () => { - const mockLayout = () => null; - const Customlayout = scaffolderPlugin.provide( - createScaffolderLayout({ - name: 'CustomLayout', - component: mockLayout, - }), - ); - - await renderInTestApp( - - - - - , - { routeEntries: ['/templates/default/foo'] }, - ); - - const mock = TemplateWizardPage as jest.Mock; - // eslint-disable-next-line no-console - const [{ layout }] = mock.mock.calls[0]; - - expect(layout).toEqual({ name: 'CustomLayout', component: mockLayout }); - }); }); }); diff --git a/plugins/scaffolder/src/next/Router/Router.tsx b/plugins/scaffolder/src/next/Router/Router.tsx index 5934206564..758e268cb3 100644 --- a/plugins/scaffolder/src/next/Router/Router.tsx +++ b/plugins/scaffolder/src/next/Router/Router.tsx @@ -29,12 +29,6 @@ import { TemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common'; import { TemplateGroupFilter } from '../TemplateListPage/TemplateGroups'; import { nextSelectedTemplateRouteRef } from '../../routes'; import { SecretsContextProvider } from '../../components/secrets/SecretsContext'; -import { - DEFAULT_SCAFFOLDER_LAYOUT, - LayoutOptions, - LAYOUTS_KEY, - LAYOUTS_WRAPPER_KEY, -} from '../../layouts'; /** * The Props for the Scaffolder Router @@ -81,24 +75,6 @@ export const Router = (props: PropsWithChildren) => { ), ]; - const customLayouts = useElementFilter(outlet, elements => - elements - .selectByComponentData({ - key: LAYOUTS_WRAPPER_KEY, - }) - .findComponentData({ - key: LAYOUTS_KEY, - }), - ); - - if ( - !customLayouts.find( - layout => layout.name === DEFAULT_SCAFFOLDER_LAYOUT.name, - ) - ) { - customLayouts.push(DEFAULT_SCAFFOLDER_LAYOUT); - } - return ( ) => { path={nextSelectedTemplateRouteRef.path} element={ - + } /> diff --git a/plugins/scaffolder/src/next/TemplateWizardPage/Stepper/Stepper.test.tsx b/plugins/scaffolder/src/next/TemplateWizardPage/Stepper/Stepper.test.tsx index 5d24c19972..f605e9c114 100644 --- a/plugins/scaffolder/src/next/TemplateWizardPage/Stepper/Stepper.test.tsx +++ b/plugins/scaffolder/src/next/TemplateWizardPage/Stepper/Stepper.test.tsx @@ -18,7 +18,6 @@ import { TemplateParameterSchema } from '../../../types'; import { Stepper } from './Stepper'; import { renderInTestApp } from '@backstage/test-utils'; import { act, fireEvent } from '@testing-library/react'; -import { DEFAULT_SCAFFOLDER_LAYOUT } from '../../../layouts'; describe('Stepper', () => { it('should render the step titles for each step of the manifest', async () => { @@ -31,11 +30,7 @@ describe('Stepper', () => { }; const { getByText } = await renderInTestApp( - , + , ); for (const step of manifest.steps) { @@ -139,7 +134,6 @@ describe('Stepper', () => { , ); diff --git a/plugins/scaffolder/src/next/TemplateWizardPage/TemplateWizardPage.tsx b/plugins/scaffolder/src/next/TemplateWizardPage/TemplateWizardPage.tsx index e29c903e25..468db438d5 100644 --- a/plugins/scaffolder/src/next/TemplateWizardPage/TemplateWizardPage.tsx +++ b/plugins/scaffolder/src/next/TemplateWizardPage/TemplateWizardPage.tsx @@ -37,11 +37,9 @@ import { makeStyles } from '@material-ui/core'; import { Stepper } from './Stepper'; import { BackstageTheme } from '@backstage/theme'; import { nextRouteRef, selectedTemplateRouteRef } from '../../routes'; -import type { LayoutOptions } from '../../layouts'; export interface TemplateWizardPageProps { customFieldExtensions: FieldExtensionOptions[]; - layouts: LayoutOptions[]; } const useStyles = makeStyles(() => ({ @@ -115,7 +113,6 @@ export const TemplateWizardPage = (props: TemplateWizardPageProps) => { )}