From 4f14cae16e6273595a7e9f564ff7c3d7b1ff8e8e Mon Sep 17 00:00:00 2001 From: Philipp Hugenroth Date: Tue, 18 Jul 2023 16:54:54 +0200 Subject: [PATCH] Fix tsc Co-authored-by: Vincenzo Scamporlino Signed-off-by: Philipp Hugenroth --- packages/cli/src/lib/bundler/server.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/cli/src/lib/bundler/server.ts b/packages/cli/src/lib/bundler/server.ts index db046e1e18..653f02f5a5 100644 --- a/packages/cli/src/lib/bundler/server.ts +++ b/packages/cli/src/lib/bundler/server.ts @@ -45,7 +45,7 @@ export async function serveBundle(options: ServeOptions) { const packageDetectionMode = options.fullConfig.getOptional( 'app.experimental.packages', ); - const extraPackages = []; + const extraPackages: string[] = []; if (packageDetectionMode === 'all') { for (const depName of Object.keys(pkg.dependencies ?? {})) { const depPackageJson: BackstagePackageJson = require(require.resolve( @@ -61,9 +61,10 @@ export async function serveBundle(options: ServeOptions) { } } } else { - const packagesList = Array.isArray(packageDetectionMode) - ? packageDetectionMode - : []; + const packagesList = options.fullConfig.getStringArray( + 'app.experimental.packages', + ); + for (const depName of packagesList ?? []) { const depPackageJson: BackstagePackageJson = require(require.resolve( `${depName}/package.json`, @@ -203,7 +204,6 @@ export async function serveBundle(options: ServeOptions) { : false, host, port, - proxy: pkg.proxy, // When the dev server is behind a proxy, the host and public hostname differ allowedHosts: [url.hostname], client: {