From 4ee89f74ac6787cf9bcfbc1494d8562e480011a9 Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Thu, 16 Jul 2020 14:17:04 +0200
Subject: [PATCH] chore(scaffolder): fixing more tests

---
 .../src/scaffolder/stages/templater/helpers.test.ts   | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/plugins/scaffolder-backend/src/scaffolder/stages/templater/helpers.test.ts b/plugins/scaffolder-backend/src/scaffolder/stages/templater/helpers.test.ts
index 3e59ed50cb..e04ba48324 100644
--- a/plugins/scaffolder-backend/src/scaffolder/stages/templater/helpers.test.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/stages/templater/helpers.test.ts
@@ -17,7 +17,6 @@ import Stream, { PassThrough } from 'stream';
 import os from 'os';
 import fs from 'fs';
 import Docker from 'dockerode';
-import { Writable } from 'stream';
 import { runDockerContainer } from './helpers';
 
 describe('helpers', () => {
@@ -30,9 +29,9 @@ describe('helpers', () => {
     jest.spyOn(mockDocker, 'pull').mockImplementation((async (
       _image: string,
       _something: any,
-      handler: (err: Error | undefined, stream: Writable) => void,
+      handler: (err: Error | undefined, stream: PassThrough) => void,
     ) => {
-      const mockStream = new Writable();
+      const mockStream = new PassThrough();
       handler(undefined, mockStream);
       mockStream.end();
     }) as any);
@@ -53,7 +52,11 @@ describe('helpers', () => {
         dockerClient: mockDocker,
       });
 
-      expect(mockDocker.pull).toHaveBeenCalledWith(imageName, {});
+      expect(mockDocker.pull).toHaveBeenCalledWith(
+        imageName,
+        {},
+        expect.any(Function),
+      );
     });
     it('should call the dockerClient run command with the correct arguments passed through', async () => {
       await runDockerContainer({