From 4e7db4beb2cdd8f4916ddafe43987ee64e6d0c8e Mon Sep 17 00:00:00 2001 From: deepthi-28 Date: Thu, 20 Mar 2025 11:44:01 +0530 Subject: [PATCH] Renamed the dialogue box and in changeset description corrected Signed-off-by: deepthi-28 --- .changeset/deep-flies-vanish.md | 2 +- ...eEntityDialog.tsx => DeleteEntityConfirmationDialog.tsx} | 6 ++++-- .../src/components/FailedEntities.tsx | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) rename plugins/catalog-unprocessed-entities/src/components/{DeleteEntityDialog.tsx => DeleteEntityConfirmationDialog.tsx} (92%) diff --git a/.changeset/deep-flies-vanish.md b/.changeset/deep-flies-vanish.md index 8ae47e9b81..30aa10f290 100644 --- a/.changeset/deep-flies-vanish.md +++ b/.changeset/deep-flies-vanish.md @@ -2,4 +2,4 @@ '@backstage/plugin-catalog-unprocessed-entities': patch --- -Added confirmation popup for delete entities in devtools +Added confirmation popup for delete entities in Catalog Unprocessed Entities plugin diff --git a/plugins/catalog-unprocessed-entities/src/components/DeleteEntityDialog.tsx b/plugins/catalog-unprocessed-entities/src/components/DeleteEntityConfirmationDialog.tsx similarity index 92% rename from plugins/catalog-unprocessed-entities/src/components/DeleteEntityDialog.tsx rename to plugins/catalog-unprocessed-entities/src/components/DeleteEntityConfirmationDialog.tsx index a1843b43b6..be93817d69 100644 --- a/plugins/catalog-unprocessed-entities/src/components/DeleteEntityDialog.tsx +++ b/plugins/catalog-unprocessed-entities/src/components/DeleteEntityConfirmationDialog.tsx @@ -21,13 +21,15 @@ import DialogTitle from '@material-ui/core/DialogTitle'; import React, { useState } from 'react'; import { assertError } from '@backstage/errors'; -interface DeleteEntityDialogProps { +interface DeleteEntityConfirmationProps { open: boolean; onClose: () => any; onConfirm: () => any; } -export function DeleteEntityDialog(props: DeleteEntityDialogProps) { +export function DeleteEntityConfirmationDialog( + props: DeleteEntityConfirmationProps, +) { const { open, onClose, onConfirm } = props; const [busy, setBusy] = useState(false); const onDelete = async () => { diff --git a/plugins/catalog-unprocessed-entities/src/components/FailedEntities.tsx b/plugins/catalog-unprocessed-entities/src/components/FailedEntities.tsx index 26d3fd8b5b..ef77d16bad 100644 --- a/plugins/catalog-unprocessed-entities/src/components/FailedEntities.tsx +++ b/plugins/catalog-unprocessed-entities/src/components/FailedEntities.tsx @@ -34,7 +34,7 @@ import { EntityDialog } from './EntityDialog'; import { catalogUnprocessedEntitiesApiRef } from '../api'; import useAsync from 'react-use/esm/useAsync'; import DeleteIcon from '@material-ui/icons/Delete'; -import { DeleteEntityDialog } from './DeleteEntityDialog'; +import { DeleteEntityConfirmationDialog } from './DeleteEntityConfirmationDialog'; const useStyles = makeStyles((theme: Theme) => ({ errorBox: { @@ -274,7 +274,7 @@ export const FailedEntities = () => { ); }} /> - setConfirmationDialogOpen(false)} onConfirm={cleanUpAfterRemoval}