From 4e39e634526f81d9e81d07194f3b3c3b9b0220dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Thu, 19 Feb 2026 11:48:39 +0100 Subject: [PATCH] scaffolder: remove unused modules MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .changeset/polite-singers-lead.md | 5 ++++ plugins/scaffolder-backend/knip-report.md | 25 ------------------- plugins/scaffolder-backend/package.json | 14 ----------- .../src/service/router.test.ts | 6 ----- yarn.lock | 24 ++++-------------- 5 files changed, 10 insertions(+), 64 deletions(-) create mode 100644 .changeset/polite-singers-lead.md diff --git a/.changeset/polite-singers-lead.md b/.changeset/polite-singers-lead.md new file mode 100644 index 0000000000..0aa775e4e2 --- /dev/null +++ b/.changeset/polite-singers-lead.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-backend': patch +--- + +Removed unused dependencies diff --git a/plugins/scaffolder-backend/knip-report.md b/plugins/scaffolder-backend/knip-report.md index eb8ddd05aa..2661c35327 100644 --- a/plugins/scaffolder-backend/knip-report.md +++ b/plugins/scaffolder-backend/knip-report.md @@ -1,27 +1,2 @@ # Knip report -## Unused dependencies (14) - -| Name | Location | Severity | -| :--------------------------------------------------------------- | :----------- | :------- | -| @backstage/plugin-catalog-backend-module-scaffolder-entity-model | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-scaffolder-backend-module-bitbucket-server | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-scaffolder-backend-module-bitbucket-cloud | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-scaffolder-backend-module-bitbucket | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-scaffolder-backend-module-gerrit | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-scaffolder-backend-module-github | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-scaffolder-backend-module-gitlab | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-scaffolder-backend-module-azure | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-scaffolder-backend-module-gitea | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-bitbucket-cloud-common | plugins/scaffolder-backend/package.json | error | -| @backstage/plugin-auth-node | plugins/scaffolder-backend/package.json | error | -| concat-stream | plugins/scaffolder-backend/package.json | error | -| p-limit | plugins/scaffolder-backend/package.json | error | -| tar | plugins/scaffolder-backend/package.json | error | - -## Unused devDependencies (1) - -| Name | Location | Severity | -| :------------------------- | :----------- | :------- | -| @backstage/backend-app-api | plugins/scaffolder-backend/package.json | error | - diff --git a/plugins/scaffolder-backend/package.json b/plugins/scaffolder-backend/package.json index 48dc528587..d26941076a 100644 --- a/plugins/scaffolder-backend/package.json +++ b/plugins/scaffolder-backend/package.json @@ -71,27 +71,15 @@ "@backstage/config": "workspace:^", "@backstage/errors": "workspace:^", "@backstage/integration": "workspace:^", - "@backstage/plugin-auth-node": "workspace:^", - "@backstage/plugin-bitbucket-cloud-common": "workspace:^", - "@backstage/plugin-catalog-backend-module-scaffolder-entity-model": "workspace:^", "@backstage/plugin-catalog-node": "workspace:^", "@backstage/plugin-events-node": "workspace:^", "@backstage/plugin-permission-common": "workspace:^", "@backstage/plugin-permission-node": "workspace:^", - "@backstage/plugin-scaffolder-backend-module-azure": "workspace:^", - "@backstage/plugin-scaffolder-backend-module-bitbucket": "workspace:^", - "@backstage/plugin-scaffolder-backend-module-bitbucket-cloud": "workspace:^", - "@backstage/plugin-scaffolder-backend-module-bitbucket-server": "workspace:^", - "@backstage/plugin-scaffolder-backend-module-gerrit": "workspace:^", - "@backstage/plugin-scaffolder-backend-module-gitea": "workspace:^", - "@backstage/plugin-scaffolder-backend-module-github": "workspace:^", - "@backstage/plugin-scaffolder-backend-module-gitlab": "workspace:^", "@backstage/plugin-scaffolder-common": "workspace:^", "@backstage/plugin-scaffolder-node": "workspace:^", "@backstage/types": "workspace:^", "@opentelemetry/api": "^1.9.0", "@types/luxon": "^3.0.0", - "concat-stream": "^2.0.0", "express": "^4.22.0", "fs-extra": "^11.2.0", "globby": "^11.0.0", @@ -103,7 +91,6 @@ "logform": "^2.3.2", "luxon": "^3.0.0", "nunjucks": "^3.2.3", - "p-limit": "^3.1.0", "p-queue": "^6.6.2", "prom-client": "^15.0.0", "triple-beam": "^1.4.1", @@ -116,7 +103,6 @@ "zod-to-json-schema": "^3.25.1" }, "devDependencies": { - "@backstage/backend-app-api": "workspace:^", "@backstage/backend-defaults": "workspace:^", "@backstage/backend-test-utils": "workspace:^", "@backstage/cli": "workspace:^", diff --git a/plugins/scaffolder-backend/src/service/router.test.ts b/plugins/scaffolder-backend/src/service/router.test.ts index 16a6000224..ab1f5cd583 100644 --- a/plugins/scaffolder-backend/src/service/router.test.ts +++ b/plugins/scaffolder-backend/src/service/router.test.ts @@ -20,12 +20,6 @@ import express from 'express'; import request from 'supertest'; import ObservableImpl from 'zen-observable'; -/** - * TODO: The following should import directly from the router file. - * Due to a circular dependency between this plugin and the - * plugin-scaffolder-backend-module-cookiecutter plugin, it results in an error: - * TypeError: _pluginscaffolderbackend.createTemplateAction is not a function - */ import { parseEntityRef, stringifyEntityRef, diff --git a/yarn.lock b/yarn.lock index b6e44d502a..9f01085037 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6691,7 +6691,7 @@ __metadata: languageName: unknown linkType: soft -"@backstage/plugin-scaffolder-backend-module-azure@workspace:^, @backstage/plugin-scaffolder-backend-module-azure@workspace:plugins/scaffolder-backend-module-azure": +"@backstage/plugin-scaffolder-backend-module-azure@workspace:plugins/scaffolder-backend-module-azure": version: 0.0.0-use.local resolution: "@backstage/plugin-scaffolder-backend-module-azure@workspace:plugins/scaffolder-backend-module-azure" dependencies: @@ -6746,7 +6746,7 @@ __metadata: languageName: unknown linkType: soft -"@backstage/plugin-scaffolder-backend-module-bitbucket@workspace:^, @backstage/plugin-scaffolder-backend-module-bitbucket@workspace:plugins/scaffolder-backend-module-bitbucket": +"@backstage/plugin-scaffolder-backend-module-bitbucket@workspace:plugins/scaffolder-backend-module-bitbucket": version: 0.0.0-use.local resolution: "@backstage/plugin-scaffolder-backend-module-bitbucket@workspace:plugins/scaffolder-backend-module-bitbucket" dependencies: @@ -6826,7 +6826,7 @@ __metadata: languageName: unknown linkType: soft -"@backstage/plugin-scaffolder-backend-module-gerrit@workspace:^, @backstage/plugin-scaffolder-backend-module-gerrit@workspace:plugins/scaffolder-backend-module-gerrit": +"@backstage/plugin-scaffolder-backend-module-gerrit@workspace:plugins/scaffolder-backend-module-gerrit": version: 0.0.0-use.local resolution: "@backstage/plugin-scaffolder-backend-module-gerrit@workspace:plugins/scaffolder-backend-module-gerrit" dependencies: @@ -6843,7 +6843,7 @@ __metadata: languageName: unknown linkType: soft -"@backstage/plugin-scaffolder-backend-module-gitea@workspace:^, @backstage/plugin-scaffolder-backend-module-gitea@workspace:plugins/scaffolder-backend-module-gitea": +"@backstage/plugin-scaffolder-backend-module-gitea@workspace:plugins/scaffolder-backend-module-gitea": version: 0.0.0-use.local resolution: "@backstage/plugin-scaffolder-backend-module-gitea@workspace:plugins/scaffolder-backend-module-gitea" dependencies: @@ -6887,7 +6887,7 @@ __metadata: languageName: unknown linkType: soft -"@backstage/plugin-scaffolder-backend-module-gitlab@workspace:^, @backstage/plugin-scaffolder-backend-module-gitlab@workspace:plugins/scaffolder-backend-module-gitlab": +"@backstage/plugin-scaffolder-backend-module-gitlab@workspace:plugins/scaffolder-backend-module-gitlab": version: 0.0.0-use.local resolution: "@backstage/plugin-scaffolder-backend-module-gitlab@workspace:plugins/scaffolder-backend-module-gitlab" dependencies: @@ -6980,7 +6980,6 @@ __metadata: version: 0.0.0-use.local resolution: "@backstage/plugin-scaffolder-backend@workspace:plugins/scaffolder-backend" dependencies: - "@backstage/backend-app-api": "workspace:^" "@backstage/backend-defaults": "workspace:^" "@backstage/backend-openapi-utils": "workspace:^" "@backstage/backend-plugin-api": "workspace:^" @@ -6990,21 +6989,10 @@ __metadata: "@backstage/config": "workspace:^" "@backstage/errors": "workspace:^" "@backstage/integration": "workspace:^" - "@backstage/plugin-auth-node": "workspace:^" - "@backstage/plugin-bitbucket-cloud-common": "workspace:^" - "@backstage/plugin-catalog-backend-module-scaffolder-entity-model": "workspace:^" "@backstage/plugin-catalog-node": "workspace:^" "@backstage/plugin-events-node": "workspace:^" "@backstage/plugin-permission-common": "workspace:^" "@backstage/plugin-permission-node": "workspace:^" - "@backstage/plugin-scaffolder-backend-module-azure": "workspace:^" - "@backstage/plugin-scaffolder-backend-module-bitbucket": "workspace:^" - "@backstage/plugin-scaffolder-backend-module-bitbucket-cloud": "workspace:^" - "@backstage/plugin-scaffolder-backend-module-bitbucket-server": "workspace:^" - "@backstage/plugin-scaffolder-backend-module-gerrit": "workspace:^" - "@backstage/plugin-scaffolder-backend-module-gitea": "workspace:^" - "@backstage/plugin-scaffolder-backend-module-github": "workspace:^" - "@backstage/plugin-scaffolder-backend-module-gitlab": "workspace:^" "@backstage/plugin-scaffolder-common": "workspace:^" "@backstage/plugin-scaffolder-node": "workspace:^" "@backstage/plugin-scaffolder-node-test-utils": "workspace:^" @@ -7017,7 +7005,6 @@ __metadata: "@types/nunjucks": "npm:^3.1.4" "@types/supertest": "npm:^2.0.8" "@types/zen-observable": "npm:^0.8.0" - concat-stream: "npm:^2.0.0" esbuild: "npm:^0.27.0" express: "npm:^4.22.0" fs-extra: "npm:^11.2.0" @@ -7030,7 +7017,6 @@ __metadata: logform: "npm:^2.3.2" luxon: "npm:^3.0.0" nunjucks: "npm:^3.2.3" - p-limit: "npm:^3.1.0" p-queue: "npm:^6.6.2" prom-client: "npm:^15.0.0" strip-ansi: "npm:^7.1.0"