From 05eb98f06918bc6617a4b4a385c51a10a38442c9 Mon Sep 17 00:00:00 2001 From: Nikolai Thingnes Leira <140617589+NikolaiTL@users.noreply.github.com> Date: Fri, 8 Nov 2024 16:23:45 +0100 Subject: [PATCH 1/3] docs: add info about dockerignore Signed-off-by: Nikolai Thingnes Leira <140617589+NikolaiTL@users.noreply.github.com> --- docs/tutorials/setup-opentelemetry.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/tutorials/setup-opentelemetry.md b/docs/tutorials/setup-opentelemetry.md index cba8ba7049..ea3351245a 100644 --- a/docs/tutorials/setup-opentelemetry.md +++ b/docs/tutorials/setup-opentelemetry.md @@ -66,6 +66,12 @@ You can now start your Backstage instance as usual, using `yarn dev`. ## Production Setup +In your '.dockerignore', add this line: +``` +!packages/backend/src/instrumentation.js +``` +This ensures that Docker build will not ignore the instrumentation file if you are following the recommended `.dockerignore` setup. + In your `Dockerfile`, copy `instrumentation.js` file into the root of the working directory. ```Dockerfile From 913a4593e31735f034500177149aa1d55cd5279d Mon Sep 17 00:00:00 2001 From: Nikolai Thingnes Leira <140617589+NikolaiTL@users.noreply.github.com> Date: Fri, 8 Nov 2024 17:03:09 +0100 Subject: [PATCH 2/3] chore: add newlines before and after codeblock Signed-off-by: Nikolai Thingnes Leira <140617589+NikolaiTL@users.noreply.github.com> --- docs/tutorials/setup-opentelemetry.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/tutorials/setup-opentelemetry.md b/docs/tutorials/setup-opentelemetry.md index ea3351245a..ae46f87aa3 100644 --- a/docs/tutorials/setup-opentelemetry.md +++ b/docs/tutorials/setup-opentelemetry.md @@ -67,9 +67,11 @@ You can now start your Backstage instance as usual, using `yarn dev`. ## Production Setup In your '.dockerignore', add this line: + ``` !packages/backend/src/instrumentation.js ``` + This ensures that Docker build will not ignore the instrumentation file if you are following the recommended `.dockerignore` setup. In your `Dockerfile`, copy `instrumentation.js` file into the root of the working directory. From 14c18b56c30567549f3a656ab22527c90ad3b185 Mon Sep 17 00:00:00 2001 From: Nikolai Thingnes Leira <140617589+NikolaiTL@users.noreply.github.com> Date: Fri, 8 Nov 2024 17:04:18 +0100 Subject: [PATCH 3/3] fix: backticks formatting Signed-off-by: Nikolai Thingnes Leira <140617589+NikolaiTL@users.noreply.github.com> --- docs/tutorials/setup-opentelemetry.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/setup-opentelemetry.md b/docs/tutorials/setup-opentelemetry.md index ae46f87aa3..c7687f1ab9 100644 --- a/docs/tutorials/setup-opentelemetry.md +++ b/docs/tutorials/setup-opentelemetry.md @@ -66,7 +66,7 @@ You can now start your Backstage instance as usual, using `yarn dev`. ## Production Setup -In your '.dockerignore', add this line: +In your `.dockerignore`, add this line: ``` !packages/backend/src/instrumentation.js