From 4ded6c62003f2c198c7b22d1a4152bcb961c8b8f Mon Sep 17 00:00:00 2001 From: Bridget Barnes Date: Tue, 3 May 2022 13:48:06 +1000 Subject: [PATCH] Fixes invalid aria- attribute Signed-off-by: Bridget Barnes --- .../src/components/EntityContextMenu/EntityContextMenu.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/plugins/catalog/src/components/EntityContextMenu/EntityContextMenu.tsx b/plugins/catalog/src/components/EntityContextMenu/EntityContextMenu.tsx index ee677c5238..5664186ab1 100644 --- a/plugins/catalog/src/components/EntityContextMenu/EntityContextMenu.tsx +++ b/plugins/catalog/src/components/EntityContextMenu/EntityContextMenu.tsx @@ -109,9 +109,12 @@ export function EntityContextMenu(props: EntityContextMenuProps) { aria-label="more" aria-controls="long-menu" aria-haspopup="true" + aria-expanded={!!anchorEl} + role="button" onClick={onOpen} data-testid="menu-button" className={classes.button} + id="long-menu" > @@ -121,6 +124,7 @@ export function EntityContextMenu(props: EntityContextMenuProps) { anchorEl={anchorEl} anchorOrigin={{ vertical: 'bottom', horizontal: 'right' }} transformOrigin={{ vertical: 'top', horizontal: 'right' }} + aria-labelledby="long-menu" > {extraItems}