From 4db039ad7fb83d4545ba1e971b9c4378d99e95f6 Mon Sep 17 00:00:00 2001 From: Hghtwr Date: Thu, 13 Feb 2025 20:18:51 +0100 Subject: [PATCH] fix: encode group path for getGroupByPath (#28826) Signed-off-by: Hghtwr --- .changeset/sour-kids-nail.md | 5 +++++ plugins/catalog-backend-module-gitlab/src/lib/client.ts | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .changeset/sour-kids-nail.md diff --git a/.changeset/sour-kids-nail.md b/.changeset/sour-kids-nail.md new file mode 100644 index 0000000000..591f13123a --- /dev/null +++ b/.changeset/sour-kids-nail.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-backend-module-gitlab': patch +--- + +Fix GitlabOrgDiscoveryEntityProvider group path not being encoded causing 404 when using a subgroup in config.group diff --git a/plugins/catalog-backend-module-gitlab/src/lib/client.ts b/plugins/catalog-backend-module-gitlab/src/lib/client.ts index 561f38634b..f5ed760b21 100644 --- a/plugins/catalog-backend-module-gitlab/src/lib/client.ts +++ b/plugins/catalog-backend-module-gitlab/src/lib/client.ts @@ -174,7 +174,10 @@ export class GitLabClient { groupPath: string, options?: CommonListOptions, ): Promise { - return this.nonPagedRequest(`/groups/${groupPath}`, options); + return this.nonPagedRequest( + `/groups/${encodeURIComponent(groupPath)}`, + options, + ); } async listDescendantGroups(