From 4d97ec07fa44540ea3a99f4e5ec73c279ad73626 Mon Sep 17 00:00:00 2001
From: Johan Haals <johan.haals@gmail.com>
Date: Thu, 18 Nov 2021 14:56:32 +0100
Subject: [PATCH] Update tests

Signed-off-by: Johan Haals <johan.haals@gmail.com>
---
 .changeset/afraid-chairs-warn.md              |  1 +
 .../errors/src/serialization/response.test.ts | 62 ++++++++++---------
 2 files changed, 35 insertions(+), 28 deletions(-)

diff --git a/.changeset/afraid-chairs-warn.md b/.changeset/afraid-chairs-warn.md
index d837744255..1ae2a7513e 100644
--- a/.changeset/afraid-chairs-warn.md
+++ b/.changeset/afraid-chairs-warn.md
@@ -3,3 +3,4 @@
 ---
 
 Deprecate `parseErrorResponse` in favour of `parseErrorResponseBody`. Deprecate `data` field inside `ErrorResponse` in favour of `body`.
+Rename the error name for unknown errors from `unknown` to `error`.
diff --git a/packages/errors/src/serialization/response.test.ts b/packages/errors/src/serialization/response.test.ts
index 54a3641657..fe1cc1e9c4 100644
--- a/packages/errors/src/serialization/response.test.ts
+++ b/packages/errors/src/serialization/response.test.ts
@@ -14,11 +14,11 @@
  * limitations under the License.
  */
 
-import { parseErrorResponse, ErrorResponse } from './response';
+import { parseErrorResponseBody, ErrorResponseBody } from './response';
 
-describe('parseErrorResponse', () => {
+describe('parseErrorResponseBody', () => {
   it('handles the happy path', async () => {
-    const body: ErrorResponse = {
+    const body: ErrorResponseBody = {
       error: { name: 'Fours', message: 'Expected fives', stack: 'lines' },
       request: { method: 'GET', url: '/' },
       response: { statusCode: 444 },
@@ -31,13 +31,13 @@ describe('parseErrorResponse', () => {
       headers: new Headers({ 'Content-Type': 'application/json' }),
     };
 
-    await expect(parseErrorResponse(response as Response)).resolves.toEqual(
+    await expect(parseErrorResponseBody(response as Response)).resolves.toEqual(
       body,
     );
   });
 
   it('uses request header and text body when wrong content type, even if parsable', async () => {
-    const body: ErrorResponse = {
+    const body: ErrorResponseBody = {
       error: { name: 'Threes', message: 'Expected twos' },
       request: { method: 'GET', url: '/' },
       response: { statusCode: 333 },
@@ -50,19 +50,21 @@ describe('parseErrorResponse', () => {
       headers: new Headers({ 'Content-Type': 'not-application/not-json' }),
     };
 
-    await expect(parseErrorResponse(response as Response)).resolves.toEqual({
-      error: {
-        name: 'Unknown',
-        message: `Request failed with status 444 Fours, ${JSON.stringify(
-          body,
-        )}`,
+    await expect(parseErrorResponseBody(response as Response)).resolves.toEqual(
+      {
+        error: {
+          name: 'Error',
+          message: `Request failed with status 444 Fours, ${JSON.stringify(
+            body,
+          )}`,
+        },
+        response: { statusCode: 444 },
       },
-      response: { statusCode: 444 },
-    });
+    );
   });
 
   it('uses request header and text body when not parsable', async () => {
-    const body: ErrorResponse = {
+    const body: ErrorResponseBody = {
       error: { name: 'Threes', message: 'Expected twos' },
       request: { method: 'GET', url: '/' },
       response: { statusCode: 333 },
@@ -75,15 +77,17 @@ describe('parseErrorResponse', () => {
       headers: new Headers({ 'Content-Type': 'application/json' }),
     };
 
-    await expect(parseErrorResponse(response as Response)).resolves.toEqual({
-      error: {
-        name: 'Unknown',
-        message: `Request failed with status 444 Fours, ${JSON.stringify(
-          body,
-        ).substring(1)}`,
+    await expect(parseErrorResponseBody(response as Response)).resolves.toEqual(
+      {
+        error: {
+          name: 'Error',
+          message: `Request failed with status 444 Fours, ${JSON.stringify(
+            body,
+          ).substring(1)}`,
+        },
+        response: { statusCode: 444 },
       },
-      response: { statusCode: 444 },
-    });
+    );
   });
 
   it('uses request header when failing to get body', async () => {
@@ -96,12 +100,14 @@ describe('parseErrorResponse', () => {
       headers: new Headers({ 'Content-Type': 'application/json' }),
     };
 
-    await expect(parseErrorResponse(response as Response)).resolves.toEqual({
-      error: {
-        name: 'Unknown',
-        message: `Request failed with status 444 Fours`,
+    await expect(parseErrorResponseBody(response as Response)).resolves.toEqual(
+      {
+        error: {
+          name: 'Error',
+          message: `Request failed with status 444 Fours`,
+        },
+        response: { statusCode: 444 },
       },
-      response: { statusCode: 444 },
-    });
+    );
   });
 });