From 439e9848482854f5d2eaa409c15e20dcc10c96e4 Mon Sep 17 00:00:00 2001 From: inductor Date: Tue, 17 Mar 2020 12:46:59 +0900 Subject: [PATCH 1/7] Add docker environment --- .dockerignore | 6 ++++++ Dockerfile | 16 ++++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 .dockerignore create mode 100644 Dockerfile diff --git a/.dockerignore b/.dockerignore new file mode 100644 index 0000000000..2fac00fd6d --- /dev/null +++ b/.dockerignore @@ -0,0 +1,6 @@ +.git +node_modules +packages/*/node_modules +packages/*/dist +plugins/*/node_modules +plugins/*/dist diff --git a/Dockerfile b/Dockerfile new file mode 100644 index 0000000000..3e5ccc7fd7 --- /dev/null +++ b/Dockerfile @@ -0,0 +1,16 @@ +FROM node:12 as builder + +WORKDIR /app + +COPY package.json yarn.lock .yarnrc .npmrc /app/ +COPY .yarn /app/.yarn +COPY packages /app/packages +COPY plugins /app/plugins + +RUN yarn + +COPY . . + +RUN yarn build + +CMD ["yarn", "workspace", "@spotify-backstage/app", "start"] From e646487eb0aeeb36b4805c88481ff37e20194a9b Mon Sep 17 00:00:00 2001 From: inductor Date: Tue, 17 Mar 2020 12:49:05 +0900 Subject: [PATCH 2/7] Add Docker section in README --- README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index 4f180474af..9c94c49710 100644 --- a/README.md +++ b/README.md @@ -57,6 +57,17 @@ $ yarn start The final `yarn start` command should open a local instance of Backstage in your browser, otherwise open one of the URLs printed in the terminal. +### (Optional)Try on Docker + +Run the following commands if you have Docker environment + +```bash +$ docker build . -t spotify/backstage +$ docker run --rm -it -p 3000:3000 backstage +``` + +Then open http://localhost:3000/ on your browser. + ## Documentation - [Create a Plugin](docs/getting-started/create-a-plugin.md) From e3b0ec258224f36fdac6bb05847c7b261368222d Mon Sep 17 00:00:00 2001 From: inductor Date: Tue, 17 Mar 2020 12:50:58 +0900 Subject: [PATCH 3/7] remove unnecessary alias --- Dockerfile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 3e5ccc7fd7..882466b1ab 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,4 @@ -FROM node:12 as builder - +FROM node:12 WORKDIR /app COPY package.json yarn.lock .yarnrc .npmrc /app/ From 94d98aa2cb500225682c66e1752dcd1fb930d099 Mon Sep 17 00:00:00 2001 From: inductor Date: Tue, 17 Mar 2020 12:51:47 +0900 Subject: [PATCH 4/7] Add EXPOSE to speficy container port --- Dockerfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Dockerfile b/Dockerfile index 882466b1ab..cf0da72d0f 100644 --- a/Dockerfile +++ b/Dockerfile @@ -12,4 +12,6 @@ COPY . . RUN yarn build +EXPOSE 3000 + CMD ["yarn", "workspace", "@spotify-backstage/app", "start"] From 9e81cf9031b2d58c30b04690895bc7a106837faa Mon Sep 17 00:00:00 2001 From: inductor Date: Tue, 17 Mar 2020 23:29:46 +0900 Subject: [PATCH 5/7] work on nginx --- Dockerfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index cf0da72d0f..39d51a35f2 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:12 +FROM node:12 as builder WORKDIR /app COPY package.json yarn.lock .yarnrc .npmrc /app/ @@ -12,6 +12,6 @@ COPY . . RUN yarn build -EXPOSE 3000 +FROM nginx:mainline -CMD ["yarn", "workspace", "@spotify-backstage/app", "start"] +COPY --from=builder /app/packages/app/build /usr/share/nginx/html From 2fc0f23a1d6e174f2193fce06aa66bc3190138fd Mon Sep 17 00:00:00 2001 From: inductor Date: Tue, 17 Mar 2020 23:36:42 +0900 Subject: [PATCH 6/7] apply change to readme --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9c94c49710..4d90bccf05 100644 --- a/README.md +++ b/README.md @@ -63,10 +63,10 @@ Run the following commands if you have Docker environment ```bash $ docker build . -t spotify/backstage -$ docker run --rm -it -p 3000:3000 backstage +$ docker run --rm -it -p 80:80 backstage ``` -Then open http://localhost:3000/ on your browser. +Then open http://localhost/ on your browser. ## Documentation From 9f38e9518b1c60f6f76e8d58af699f261d9e8b53 Mon Sep 17 00:00:00 2001 From: inductor Date: Wed, 18 Mar 2020 08:30:25 +0900 Subject: [PATCH 7/7] fix image name --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4d90bccf05..56a3131f88 100644 --- a/README.md +++ b/README.md @@ -63,7 +63,7 @@ Run the following commands if you have Docker environment ```bash $ docker build . -t spotify/backstage -$ docker run --rm -it -p 80:80 backstage +$ docker run --rm -it -p 80:80 spotify/backstage ``` Then open http://localhost/ on your browser.