Review feedback.

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
This commit is contained in:
Eric Peterson
2021-09-30 15:47:02 +02:00
parent 0da4df22a3
commit 4d11fcf683
15 changed files with 78 additions and 46 deletions
+1 -4
View File
@@ -36,7 +36,6 @@ events to GA. All that's needed is your Universal Analytics tracking ID:
# app-config.yaml
app:
analytics:
provider: ga
ga:
trackingId: UA-0000000-0
```
@@ -58,7 +57,6 @@ to capture Plugin IDs associated with events, including page views.
```yaml
app:
analytics:
provider: ga
ga:
trackingId: UA-0000000-0
customDimensionsMetrics:
@@ -122,7 +120,7 @@ make and test changes is to do the following:
the monorepo and add config for this plugin (see below)
4. Enter this plugin's working directory: `cd plugins/analytics-provider-ga`
5. Start the plugin in isolation: `yarn start`
6. Navigate to the playground page at [/ga](http://localhost:3000/ga)
6. Navigate to the playground page at `http://localhost:3000/ga`
7. Open the web console to see events fire when you navigate or when you
interact with instrumented components.
@@ -136,7 +134,6 @@ Paste this into your `app-config.local.yaml` while developing this plugin:
```yaml
app:
analytics:
provider: ga
ga:
trackingId: UA-0000000-0
debug: true
-1
View File
@@ -20,7 +20,6 @@ export interface Config {
// context of the monorepo is too strict. Ideally, this would be marked as
// required.
analytics?: {
provider: 'ga';
ga: {
/**
* Google Analytics tracking ID, e.g. UA-000000-0