From 4d1094bef43a2a62180878f1d75239128bd4f8ac Mon Sep 17 00:00:00 2001 From: sblausten Date: Tue, 20 Dec 2022 11:45:33 +0100 Subject: [PATCH] Return all errors Signed-off-by: sblausten --- plugins/tech-insights-backend/src/service/router.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/tech-insights-backend/src/service/router.ts b/plugins/tech-insights-backend/src/service/router.ts index d9cfa9b0ad..e09114d2c7 100644 --- a/plugins/tech-insights-backend/src/service/router.ts +++ b/plugins/tech-insights-backend/src/service/router.ts @@ -103,7 +103,7 @@ export async function createRouter< checks, entities, }: { checks: string[]; entities: CompoundEntityRef[] } = req.body; - let error = undefined; + const errors: string[] = []; const tasks = entities.map(async entity => { const entityTriplet = typeof entity === 'string' ? entity : stringifyEntityRef(entity); @@ -116,7 +116,7 @@ export async function createRouter< } catch (e: any) { const errorMessage = `Failed to run check for entity ${entityTriplet} due to error: ${e.message}`; logger.error(errorMessage); - error = errorMessage; + errors.push(errorMessage); return { entity: entityTriplet, results: [], @@ -124,8 +124,8 @@ export async function createRouter< } }); const results = await Promise.all(tasks); - if (error) { - return res.status(500).send({ error, results }); + if (errors.length > 0) { + return res.status(500).send({ errors, results }); } return res.json(results); });