Address review feedback from freben
- Use cli-defaults instead of listing individual CLI modules in create-app template and root package.json - Move nodeTransform config files from cli-module-build to cli-node to avoid cross-module direct imports - Rename cli-module-create-github-app to cli-module-github - Start createCliModule init chain with Promise.resolve() - Deduplicate exitWithError in runCliModule.ts - Extract shared isCommandNodeHidden to @internal/cli - Add explanatory comment for fromArray deduplication field - Restore error for cli role packages missing bin in runCliExtraction Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com> Made-with: Cursor
This commit is contained in:
Patrik Oldsberg
@@ -2801,7 +2801,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-defaults@workspace:^, @backstage/cli-defaults@workspace:packages/cli-defaults":
|
||||
"@backstage/cli-defaults@workspace:*, @backstage/cli-defaults@workspace:^, @backstage/cli-defaults@workspace:packages/cli-defaults":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-defaults@workspace:packages/cli-defaults"
|
||||
dependencies:
|
||||
@@ -2809,7 +2809,7 @@ __metadata:
|
||||
"@backstage/cli-module-auth": "workspace:^"
|
||||
"@backstage/cli-module-build": "workspace:^"
|
||||
"@backstage/cli-module-config": "workspace:^"
|
||||
"@backstage/cli-module-create-github-app": "workspace:^"
|
||||
"@backstage/cli-module-github": "workspace:^"
|
||||
"@backstage/cli-module-info": "workspace:^"
|
||||
"@backstage/cli-module-lint": "workspace:^"
|
||||
"@backstage/cli-module-maintenance": "workspace:^"
|
||||
@@ -2820,7 +2820,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-auth@workspace:*, @backstage/cli-module-auth@workspace:^, @backstage/cli-module-auth@workspace:packages/cli-module-auth":
|
||||
"@backstage/cli-module-auth@workspace:^, @backstage/cli-module-auth@workspace:packages/cli-module-auth":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-auth@workspace:packages/cli-module-auth"
|
||||
dependencies:
|
||||
@@ -2847,7 +2847,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-build@workspace:*, @backstage/cli-module-build@workspace:^, @backstage/cli-module-build@workspace:packages/cli-module-build":
|
||||
"@backstage/cli-module-build@workspace:^, @backstage/cli-module-build@workspace:packages/cli-module-build":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-build@workspace:packages/cli-module-build"
|
||||
dependencies:
|
||||
@@ -2894,7 +2894,6 @@ __metadata:
|
||||
node-stdlib-browser: "npm:^1.3.1"
|
||||
npm-packlist: "npm:^5.0.0"
|
||||
p-queue: "npm:^6.6.2"
|
||||
pirates: "npm:^4.0.6"
|
||||
postcss: "npm:^8.1.0"
|
||||
postcss-import: "npm:^16.1.0"
|
||||
process: "npm:^0.11.10"
|
||||
@@ -2922,7 +2921,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-config@workspace:*, @backstage/cli-module-config@workspace:^, @backstage/cli-module-config@workspace:packages/cli-module-config":
|
||||
"@backstage/cli-module-config@workspace:^, @backstage/cli-module-config@workspace:packages/cli-module-config":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-config@workspace:packages/cli-module-config"
|
||||
dependencies:
|
||||
@@ -2944,9 +2943,9 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-create-github-app@workspace:*, @backstage/cli-module-create-github-app@workspace:^, @backstage/cli-module-create-github-app@workspace:packages/cli-module-create-github-app":
|
||||
"@backstage/cli-module-github@workspace:^, @backstage/cli-module-github@workspace:packages/cli-module-github":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-create-github-app@workspace:packages/cli-module-create-github-app"
|
||||
resolution: "@backstage/cli-module-github@workspace:packages/cli-module-github"
|
||||
dependencies:
|
||||
"@backstage/cli": "workspace:^"
|
||||
"@backstage/cli-common": "workspace:^"
|
||||
@@ -2962,11 +2961,11 @@ __metadata:
|
||||
react-dev-utils: "npm:^12.0.0-next.60"
|
||||
yaml: "npm:^2.0.0"
|
||||
bin:
|
||||
cli-module-create-github-app: bin/backstage-cli-module-create-github-app
|
||||
cli-module-github: bin/backstage-cli-module-github
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-info@workspace:*, @backstage/cli-module-info@workspace:^, @backstage/cli-module-info@workspace:packages/cli-module-info":
|
||||
"@backstage/cli-module-info@workspace:^, @backstage/cli-module-info@workspace:packages/cli-module-info":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-info@workspace:packages/cli-module-info"
|
||||
dependencies:
|
||||
@@ -2982,7 +2981,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-lint@workspace:*, @backstage/cli-module-lint@workspace:^, @backstage/cli-module-lint@workspace:packages/cli-module-lint":
|
||||
"@backstage/cli-module-lint@workspace:^, @backstage/cli-module-lint@workspace:packages/cli-module-lint":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-lint@workspace:packages/cli-module-lint"
|
||||
dependencies:
|
||||
@@ -3003,7 +3002,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-maintenance@workspace:*, @backstage/cli-module-maintenance@workspace:^, @backstage/cli-module-maintenance@workspace:packages/cli-module-maintenance":
|
||||
"@backstage/cli-module-maintenance@workspace:^, @backstage/cli-module-maintenance@workspace:packages/cli-module-maintenance":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-maintenance@workspace:packages/cli-module-maintenance"
|
||||
dependencies:
|
||||
@@ -3020,7 +3019,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-migrate@workspace:*, @backstage/cli-module-migrate@workspace:^, @backstage/cli-module-migrate@workspace:packages/cli-module-migrate":
|
||||
"@backstage/cli-module-migrate@workspace:^, @backstage/cli-module-migrate@workspace:packages/cli-module-migrate":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-migrate@workspace:packages/cli-module-migrate"
|
||||
dependencies:
|
||||
@@ -3047,7 +3046,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-new@workspace:*, @backstage/cli-module-new@workspace:^, @backstage/cli-module-new@workspace:packages/cli-module-new":
|
||||
"@backstage/cli-module-new@workspace:^, @backstage/cli-module-new@workspace:packages/cli-module-new":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-new@workspace:packages/cli-module-new"
|
||||
dependencies:
|
||||
@@ -3079,7 +3078,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-test-jest@workspace:*, @backstage/cli-module-test-jest@workspace:^, @backstage/cli-module-test-jest@workspace:packages/cli-module-test-jest":
|
||||
"@backstage/cli-module-test-jest@workspace:^, @backstage/cli-module-test-jest@workspace:packages/cli-module-test-jest":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-test-jest@workspace:packages/cli-module-test-jest"
|
||||
dependencies:
|
||||
@@ -3112,7 +3111,7 @@ __metadata:
|
||||
languageName: unknown
|
||||
linkType: soft
|
||||
|
||||
"@backstage/cli-module-translations@workspace:*, @backstage/cli-module-translations@workspace:^, @backstage/cli-module-translations@workspace:packages/cli-module-translations":
|
||||
"@backstage/cli-module-translations@workspace:^, @backstage/cli-module-translations@workspace:packages/cli-module-translations":
|
||||
version: 0.0.0-use.local
|
||||
resolution: "@backstage/cli-module-translations@workspace:packages/cli-module-translations"
|
||||
dependencies:
|
||||
@@ -3139,12 +3138,14 @@ __metadata:
|
||||
"@backstage/test-utils": "workspace:^"
|
||||
"@backstage/types": "workspace:^"
|
||||
"@manypkg/get-packages": "npm:^1.1.3"
|
||||
"@swc/core": "npm:^1.15.6"
|
||||
"@types/yarnpkg__lockfile": "npm:^1.1.4"
|
||||
"@yarnpkg/lockfile": "npm:^1.1.0"
|
||||
"@yarnpkg/parsers": "npm:^3.0.0"
|
||||
chalk: "npm:^4.0.0"
|
||||
commander: "npm:^12.0.0"
|
||||
fs-extra: "npm:^11.2.0"
|
||||
pirates: "npm:^4.0.6"
|
||||
semver: "npm:^7.5.3"
|
||||
yaml: "npm:^2.0.0"
|
||||
zod: "npm:^3.25.76"
|
||||
@@ -45365,17 +45366,7 @@ __metadata:
|
||||
resolution: "root@workspace:."
|
||||
dependencies:
|
||||
"@backstage/cli": "workspace:*"
|
||||
"@backstage/cli-module-auth": "workspace:*"
|
||||
"@backstage/cli-module-build": "workspace:*"
|
||||
"@backstage/cli-module-config": "workspace:*"
|
||||
"@backstage/cli-module-create-github-app": "workspace:*"
|
||||
"@backstage/cli-module-info": "workspace:*"
|
||||
"@backstage/cli-module-lint": "workspace:*"
|
||||
"@backstage/cli-module-maintenance": "workspace:*"
|
||||
"@backstage/cli-module-migrate": "workspace:*"
|
||||
"@backstage/cli-module-new": "workspace:*"
|
||||
"@backstage/cli-module-test-jest": "workspace:*"
|
||||
"@backstage/cli-module-translations": "workspace:*"
|
||||
"@backstage/cli-defaults": "workspace:*"
|
||||
"@backstage/codemods": "workspace:*"
|
||||
"@backstage/create-app": "workspace:*"
|
||||
"@backstage/e2e-test-utils": "workspace:*"
|
||||
|
||||
Reference in New Issue
Block a user