paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 39 Packages Projects Releases Wiki Activity

Address review feedback from freben

Browse Source 
- Use cli-defaults instead of listing individual CLI modules in
  create-app template and root package.json
- Move nodeTransform config files from cli-module-build to cli-node
  to avoid cross-module direct imports
- Rename cli-module-create-github-app to cli-module-github
- Start createCliModule init chain with Promise.resolve()
- Deduplicate exitWithError in runCliModule.ts
- Extract shared isCommandNodeHidden to @internal/cli
- Add explanatory comment for fromArray deduplication field
- Restore error for cli role packages missing bin in runCliExtraction

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
This commit is contained in:
Patrik Oldsberg
2026-03-16 12:55:22 +01:00
parent 26eab3bf83
commit 4d081452b1
47 changed files with 147 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/create-app/src/lib/tasks.test.ts
-11
View File
@@ -51,17 +51,6 @@ jest.mock('./versions', () => ({
root: '1.2.3',
'@backstage/cli': '1.0.0',
'@backstage/cli-defaults': '1.0.0',
'@backstage/cli-module-auth': '1.0.0',
'@backstage/cli-module-build': '1.0.0',
'@backstage/cli-module-config': '1.0.0',
'@backstage/cli-module-create-github-app': '1.0.0',
'@backstage/cli-module-info': '1.0.0',
'@backstage/cli-module-lint': '1.0.0',
'@backstage/cli-module-maintenance': '1.0.0',
'@backstage/cli-module-migrate': '1.0.0',
'@backstage/cli-module-new': '1.0.0',
'@backstage/cli-module-test-jest': '1.0.0',
'@backstage/cli-module-translations': '1.0.0',
'@backstage/backend-defaults': '1.0.0',
'@backstage/backend-tasks': '1.0.0',
'@backstage/catalog-model': '1.0.0',
packages/create-app/src/lib/versions.ts
-22
View File
@@ -39,17 +39,6 @@ import { version as catalogClient } from '../../../catalog-client/package.json';
import { version as catalogModel } from '../../../catalog-model/package.json';
import { version as cli } from '../../../cli/package.json';
import { version as cliDefaults } from '../../../cli-defaults/package.json';
import { version as cliModuleAuth } from '../../../cli-module-auth/package.json';
import { version as cliModuleBuild } from '../../../cli-module-build/package.json';
import { version as cliModuleConfig } from '../../../cli-module-config/package.json';
import { version as cliModuleCreateGithubApp } from '../../../cli-module-create-github-app/package.json';
import { version as cliModuleInfo } from '../../../cli-module-info/package.json';
import { version as cliModuleLint } from '../../../cli-module-lint/package.json';
import { version as cliModuleMaintenance } from '../../../cli-module-maintenance/package.json';
import { version as cliModuleMigrate } from '../../../cli-module-migrate/package.json';
import { version as cliModuleNew } from '../../../cli-module-new/package.json';
import { version as cliModuleTestJest } from '../../../cli-module-test-jest/package.json';
import { version as cliModuleTranslations } from '../../../cli-module-translations/package.json';
import { version as config } from '../../../config/package.json';
import { version as coreAppApi } from '../../../core-app-api/package.json';
import { version as coreCompatApi } from '../../../core-compat-api/package.json';
@@ -120,17 +109,6 @@ export const packageVersions = {
'@backstage/catalog-model': catalogModel,
'@backstage/cli': cli,
'@backstage/cli-defaults': cliDefaults,
'@backstage/cli-module-auth': cliModuleAuth,
'@backstage/cli-module-build': cliModuleBuild,
'@backstage/cli-module-config': cliModuleConfig,
'@backstage/cli-module-create-github-app': cliModuleCreateGithubApp,
'@backstage/cli-module-info': cliModuleInfo,
'@backstage/cli-module-lint': cliModuleLint,
'@backstage/cli-module-maintenance': cliModuleMaintenance,
'@backstage/cli-module-migrate': cliModuleMigrate,
'@backstage/cli-module-new': cliModuleNew,
'@backstage/cli-module-test-jest': cliModuleTestJest,
'@backstage/cli-module-translations': cliModuleTranslations,
'@backstage/config': config,
'@backstage/core-app-api': coreAppApi,
'@backstage/core-compat-api': coreCompatApi,
packages/create-app/templates/next-app/package.json.hbs
+1 -11
View File
@@ -50,17 +50,7 @@
],
"devDependencies": {
"@backstage/cli": "^{{version '@backstage/cli'}}",
"@backstage/cli-module-auth": "^{{version '@backstage/cli-module-auth'}}",
"@backstage/cli-module-build": "^{{version '@backstage/cli-module-build'}}",
"@backstage/cli-module-config": "^{{version '@backstage/cli-module-config'}}",
"@backstage/cli-module-create-github-app": "^{{version '@backstage/cli-module-create-github-app'}}",
"@backstage/cli-module-info": "^{{version '@backstage/cli-module-info'}}",
"@backstage/cli-module-lint": "^{{version '@backstage/cli-module-lint'}}",
"@backstage/cli-module-maintenance": "^{{version '@backstage/cli-module-maintenance'}}",
"@backstage/cli-module-migrate": "^{{version '@backstage/cli-module-migrate'}}",
"@backstage/cli-module-new": "^{{version '@backstage/cli-module-new'}}",
"@backstage/cli-module-test-jest": "^{{version '@backstage/cli-module-test-jest'}}",
"@backstage/cli-module-translations": "^{{version '@backstage/cli-module-translations'}}",
"@backstage/cli-defaults": "^{{version '@backstage/cli-defaults'}}",
"@backstage/e2e-test-utils": "^{{version '@backstage/e2e-test-utils'}}",
"@jest/environment-jsdom-abstract": "^30.0.0",
"@playwright/test": "^1.32.3",