From 4cf6cf3b6c2a049b086170d2b0a7cfa198ea9b23 Mon Sep 17 00:00:00 2001 From: Paul Pacheco Date: Sun, 16 Aug 2020 02:08:36 -0500 Subject: [PATCH] The backend listens to all interfaces by default (#1962) * The backend listens to all interfaces by default Previously, if you did not specify a host, it would only listen to localhost, so it would not accept connections from the network. If you use the default generated app, it is configured to listen to 0.0.0.0 which only listens to IPv4 interfaces. This changes the default behavior, just listen to all interfaces. * Add some comment --- app-config.yaml | 1 - packages/backend-common/src/service/lib/ServiceBuilderImpl.ts | 3 ++- packages/create-app/templates/default-app/app-config.yaml | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app-config.yaml b/app-config.yaml index e5df1de5d5..a0233991f8 100644 --- a/app-config.yaml +++ b/app-config.yaml @@ -5,7 +5,6 @@ app: backend: baseUrl: http://localhost:7000 listen: - host: 0.0.0.0 port: 7000 cors: origin: http://localhost:3000 diff --git a/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts b/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts index 4a51fb195c..cd8e445dd8 100644 --- a/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts +++ b/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts @@ -33,7 +33,8 @@ import { ServiceBuilder } from '../types'; import { readBaseOptions, readCorsOptions } from './config'; const DEFAULT_PORT = 7000; -const DEFAULT_HOST = 'localhost'; +// '' is express default, which listens to all interfaces +const DEFAULT_HOST = ''; export class ServiceBuilderImpl implements ServiceBuilder { private port: number | undefined; diff --git a/packages/create-app/templates/default-app/app-config.yaml b/packages/create-app/templates/default-app/app-config.yaml index addd74ab67..9fafbf4d76 100644 --- a/packages/create-app/templates/default-app/app-config.yaml +++ b/packages/create-app/templates/default-app/app-config.yaml @@ -8,7 +8,6 @@ organization: backend: baseUrl: http://localhost:7000 listen: - host: 0.0.0.0 port: 7000 cors: origin: http://localhost:3000