From 4c72edd4c03cc19f719dbd54b0ac9b1ad0362001 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Fri, 16 Feb 2024 12:17:06 +0100 Subject: [PATCH] backend-app-api: always return true from auth.isPrincipal for unknown checks Signed-off-by: Patrik Oldsberg --- .../src/services/implementations/auth/authServiceFactory.ts | 4 ++++ .../backend-test-utils/src/next/services/MockAuthService.ts | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/packages/backend-app-api/src/services/implementations/auth/authServiceFactory.ts b/packages/backend-app-api/src/services/implementations/auth/authServiceFactory.ts index dac8ae6d9e..86aeeea74d 100644 --- a/packages/backend-app-api/src/services/implementations/auth/authServiceFactory.ts +++ b/packages/backend-app-api/src/services/implementations/auth/authServiceFactory.ts @@ -147,6 +147,10 @@ class DefaultAuthService implements AuthService { | BackstageUserPrincipal | BackstageServicePrincipal; + if (type === 'unknown') { + return true; + } + if (principal.type !== type) { return false; } diff --git a/packages/backend-test-utils/src/next/services/MockAuthService.ts b/packages/backend-test-utils/src/next/services/MockAuthService.ts index b73bb7875f..6be358b83a 100644 --- a/packages/backend-test-utils/src/next/services/MockAuthService.ts +++ b/packages/backend-test-utils/src/next/services/MockAuthService.ts @@ -86,6 +86,11 @@ export class MockAuthService implements AuthService { | BackstageUserPrincipal | BackstageServicePrincipal | BackstageNonePrincipal; + + if (type === 'unknown') { + return true; + } + if (principal.type !== type) { return false; }