From 4c69686cb91d455414ea95306543ae582b361c2d Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Fri, 11 Feb 2022 11:32:35 +0100 Subject: [PATCH] cli: encode versions in upgrade helper URL Signed-off-by: Patrik Oldsberg --- packages/cli/src/commands/versions/bump.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/cli/src/commands/versions/bump.ts b/packages/cli/src/commands/versions/bump.ts index 315155ccee..b9d318bccc 100644 --- a/packages/cli/src/commands/versions/bump.ts +++ b/packages/cli/src/commands/versions/bump.ts @@ -425,7 +425,9 @@ export async function bumpBackstageJsonVersion(version: string) { const { yellow, cyan, green } = chalk; if (prevVersion) { - const link = `https://backstage.github.io/upgrade-helper/?from=${prevVersion}&to=${version}`; + const from = encodeURIComponent(prevVersion); + const to = encodeURIComponent(version); + const link = `https://backstage.github.io/upgrade-helper/?from=${from}&to=${to}`; console.log( yellow( `Upgraded from release ${green(prevVersion)} to ${green(