From 4b92638259ff7a4a0a39f3e51a81254f151609b1 Mon Sep 17 00:00:00 2001
From: Harry Hogg <hhogg@spotify.com>
Date: Mon, 18 Oct 2021 11:00:01 +0100
Subject: [PATCH] test(escapeRegExp): Just an extra test to make sure
 non-regexy strings don't get escaped

Signed-off-by: Harry Hogg <hhogg@spotify.com>
---
 packages/backend-common/src/util/escapeRegExp.test.ts | 4 ++++
 packages/backend-common/src/util/escapeRegExp.ts      | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/backend-common/src/util/escapeRegExp.test.ts b/packages/backend-common/src/util/escapeRegExp.test.ts
index 60b12739b3..13c6ae4a5a 100644
--- a/packages/backend-common/src/util/escapeRegExp.test.ts
+++ b/packages/backend-common/src/util/escapeRegExp.test.ts
@@ -16,6 +16,10 @@
 import { escapeRegExp } from './escapeRegExp';
 
 describe('escapeRegExp', () => {
+  test('does not escape non-regex characters', () => {
+    expect(escapeRegExp('Backstage Backstage')).toBe('Backstage Backstage');
+  });
+
   test('all the characters', () => {
     expect(escapeRegExp('^$\\.*+?()[]{}|')).toBe(
       '\\^\\$\\\\\\.\\*\\+\\?\\(\\)\\[\\]\\{\\}\\|',
diff --git a/packages/backend-common/src/util/escapeRegExp.ts b/packages/backend-common/src/util/escapeRegExp.ts
index 58a8d2da15..bc78967ebe 100644
--- a/packages/backend-common/src/util/escapeRegExp.ts
+++ b/packages/backend-common/src/util/escapeRegExp.ts
@@ -20,5 +20,5 @@
  * Taken from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions
  */
 export const escapeRegExp = (text: string) => {
-  return text.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  return text.replace(/[.*+?^${}(\)|[\]\\]/g, '\\$&');
 };