From 4b324c83f8bbc62f191139735cf9e4d43a100e54 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Thu, 8 Sep 2022 16:09:42 +0200
Subject: [PATCH] backend-app-api: 100% coverage of ServiceRegistry
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../src/wiring/ServiceRegistry.test.ts        | 72 ++++++++++++++++---
 1 file changed, 64 insertions(+), 8 deletions(-)

diff --git a/packages/backend-app-api/src/wiring/ServiceRegistry.test.ts b/packages/backend-app-api/src/wiring/ServiceRegistry.test.ts
index ab709dcb77..211f9ac31e 100644
--- a/packages/backend-app-api/src/wiring/ServiceRegistry.test.ts
+++ b/packages/backend-app-api/src/wiring/ServiceRegistry.test.ts
@@ -18,6 +18,7 @@ import {
   createServiceRef,
   createServiceFactory,
   ServiceRef,
+  pluginMetadataServiceRef,
 } from '@backstage/backend-plugin-api';
 import { ServiceRegistry } from './ServiceRegistry';
 
@@ -35,26 +36,23 @@ const sf1 = createServiceFactory({
 });
 
 const ref2 = createServiceRef<{ x: number }>({
+  scope: 'root',
   id: '2',
 });
 const sf2 = createServiceFactory({
   service: ref2,
   deps: {},
   factory: async () => {
-    return async () => {
-      return { x: 2 };
-    };
+    return { x: 2 };
   },
 });
 const sf2b = createServiceFactory({
   service: ref2,
   deps: {},
   factory: async () => {
-    return async () => {
-      return { x: 22 };
-    };
+    return { x: 22 };
   },
-});
+})();
 
 const refDefault1 = createServiceRef<{ x: number }>({
   id: '1',
@@ -63,7 +61,7 @@ const refDefault1 = createServiceRef<{ x: number }>({
       service,
       deps: {},
       factory: async () => async () => ({ x: 10 }),
-    }),
+    })(),
 });
 
 const refDefault2a = createServiceRef<{ x: number }>({
@@ -121,6 +119,64 @@ describe('ServiceRegistry', () => {
     );
   });
 
+  it('should not be possible for root scoped services to depend on plugin scoped services', async () => {
+    const factory = createServiceFactory({
+      service: ref2,
+      deps: { pluginDep: ref1 },
+      factory: async () => {
+        return { x: 2 };
+      },
+    });
+    const registry = new ServiceRegistry([factory, sf1]);
+    await expect(registry.get(ref2, 'catalog')).rejects.toThrow(
+      "Failed to instantiate 'root' scoped service '2' because it depends on 'plugin' scoped service '1'.",
+    );
+  });
+
+  it('should be possible for plugin scoped services to depend on root scoped services', async () => {
+    const factory = createServiceFactory({
+      service: ref1,
+      deps: { rootDep: ref2 },
+      factory: async ({ rootDep }) => {
+        return async () => ({ x: rootDep.x });
+      },
+    });
+    const registry = new ServiceRegistry([factory, sf2]);
+    await expect(registry.get(ref1, 'catalog')).resolves.toEqual({
+      x: 2,
+    });
+  });
+
+  it('should be possible for root scoped services to depend on root scoped services', async () => {
+    const ref = createServiceRef<{ x: number }>({ id: 'x', scope: 'root' });
+    const factory = createServiceFactory({
+      service: ref,
+      deps: { rootDep: ref2 },
+      factory: async ({ rootDep }) => {
+        return { x: rootDep.x };
+      },
+    });
+    const registry = new ServiceRegistry([factory, sf2]);
+    await expect(registry.get(ref, 'catalog')).resolves.toEqual({
+      x: 2,
+    });
+  });
+
+  it('should return the pluginId from the pluginMetadata service', async () => {
+    const ref = createServiceRef<{ pluginId: string }>({ id: 'x' });
+    const factory = createServiceFactory({
+      service: ref,
+      deps: { meta: pluginMetadataServiceRef },
+      factory: async ({}) => {
+        return async ({ meta }) => ({ pluginId: meta.getId() });
+      },
+    });
+    const registry = new ServiceRegistry([factory]);
+    await expect(registry.get(ref, 'catalog')).resolves.toEqual({
+      pluginId: 'catalog',
+    });
+  });
+
   it('should use the last factory for each ref', async () => {
     const registry = new ServiceRegistry([sf2, sf2b]);
     await expect(registry.get(ref2, 'catalog')).resolves.toEqual({