From 4adbda5162e9e5601a2e0127f6871afc2d2d61a1 Mon Sep 17 00:00:00 2001
From: Vincenzo Scamporlino <me@vinzscam.dev>
Date: Wed, 1 Dec 2021 17:15:47 +0100
Subject: [PATCH] Add minify option

Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
---
 packages/cli/src/commands/index.ts        |  1 +
 packages/cli/src/commands/plugin/build.ts |  4 +++-
 packages/cli/src/lib/builder/config.ts    | 11 ++++-------
 packages/cli/src/lib/builder/types.ts     |  4 +---
 4 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/packages/cli/src/commands/index.ts b/packages/cli/src/commands/index.ts
index a37d5e9ffe..accc36239e 100644
--- a/packages/cli/src/commands/index.ts
+++ b/packages/cli/src/commands/index.ts
@@ -123,6 +123,7 @@ export function registerCommands(program: CommanderStatic) {
   program
     .command('plugin:build')
     .description('Build a plugin')
+    .option('--minify', 'Minify the generated code')
     .action(lazy(() => import('./plugin/build').then(m => m.default)));
 
   program
diff --git a/packages/cli/src/commands/plugin/build.ts b/packages/cli/src/commands/plugin/build.ts
index 8a63a017a2..9c5e173989 100644
--- a/packages/cli/src/commands/plugin/build.ts
+++ b/packages/cli/src/commands/plugin/build.ts
@@ -14,10 +14,12 @@
  * limitations under the License.
  */
 
+import { Command } from 'commander';
 import { buildPackage, Output } from '../../lib/builder';
 
-export default async () => {
+export default async (cmd: Command) => {
   await buildPackage({
     outputs: new Set([Output.esm, Output.types]),
+    minify: cmd.minify,
   });
 };
diff --git a/packages/cli/src/lib/builder/config.ts b/packages/cli/src/lib/builder/config.ts
index cbc8c01557..ba60e8fea9 100644
--- a/packages/cli/src/lib/builder/config.ts
+++ b/packages/cli/src/lib/builder/config.ts
@@ -98,13 +98,10 @@ export const makeConfigs = async (
           include: /\.icon\.svg$/,
           template: svgrTemplate,
         }),
-        esbuild(
-          options.esBuild || {
-            target: 'es2019',
-            // TODO: remove this
-            minify: true,
-          },
-        ),
+        esbuild({
+          target: 'es2019',
+          minify: options.minify,
+        }),
       ],
     });
   }
diff --git a/packages/cli/src/lib/builder/types.ts b/packages/cli/src/lib/builder/types.ts
index 151fb8a71a..e88c388013 100644
--- a/packages/cli/src/lib/builder/types.ts
+++ b/packages/cli/src/lib/builder/types.ts
@@ -14,8 +14,6 @@
  * limitations under the License.
  */
 
-import type { Options } from 'rollup-plugin-esbuild';
-
 export enum Output {
   esm,
   cjs,
@@ -24,5 +22,5 @@ export enum Output {
 
 export type BuildOptions = {
   outputs: Set<Output>;
-  esBuild: Options;
+  minify?: boolean;
 };