From cf48bb8600b15309cb37fa44be98adba726d75d1 Mon Sep 17 00:00:00 2001 From: Taras Date: Tue, 26 Apr 2022 13:18:15 -0400 Subject: [PATCH 1/3] Exclude css files when build type definitions in plugins Signed-off-by: Taras --- packages/cli/src/lib/builder/config.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/cli/src/lib/builder/config.ts b/packages/cli/src/lib/builder/config.ts index fe91cedbb0..47a1873551 100644 --- a/packages/cli/src/lib/builder/config.ts +++ b/packages/cli/src/lib/builder/config.ts @@ -154,6 +154,7 @@ export async function makeRollupConfigs( file: resolvePath(distDir, 'index.d.ts'), format: 'es', }, + external: [/\.css$/], onwarn, plugins: [dts()], }); From 4d8736ededda7640e8aab88ce5b3aec756e696d2 Mon Sep 17 00:00:00 2001 From: Taras Date: Tue, 26 Apr 2022 13:19:25 -0400 Subject: [PATCH 2/3] Added changeset Signed-off-by: Taras --- .changeset/nine-geese-rest.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nine-geese-rest.md diff --git a/.changeset/nine-geese-rest.md b/.changeset/nine-geese-rest.md new file mode 100644 index 0000000000..246afafe10 --- /dev/null +++ b/.changeset/nine-geese-rest.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Changed Rollup configuration for TypeScript definition plugin to ignore css files. From a62cb70d1d177586b3079ec0b62b330aec8d6384 Mon Sep 17 00:00:00 2001 From: Taras Date: Tue, 26 Apr 2022 15:25:34 -0400 Subject: [PATCH 3/3] Add other extensions that might be a problem based on https://github.com/backstage/backstage/blob/master/packages/cli/asset-types/asset-types.d.ts Signed-off-by: Taras --- .changeset/nine-geese-rest.md | 3 ++- packages/cli/src/lib/builder/config.ts | 11 ++++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.changeset/nine-geese-rest.md b/.changeset/nine-geese-rest.md index 246afafe10..da91c6234b 100644 --- a/.changeset/nine-geese-rest.md +++ b/.changeset/nine-geese-rest.md @@ -2,4 +2,5 @@ '@backstage/cli': patch --- -Changed Rollup configuration for TypeScript definition plugin to ignore css files. +Changed Rollup configuration for TypeScript definition plugin to ignore `css`, +`scss`, `sass`, `svg`, `eot`, `woff`, `woff2` and `ttf` files. diff --git a/packages/cli/src/lib/builder/config.ts b/packages/cli/src/lib/builder/config.ts index 47a1873551..1cfaf15bfc 100644 --- a/packages/cli/src/lib/builder/config.ts +++ b/packages/cli/src/lib/builder/config.ts @@ -154,7 +154,16 @@ export async function makeRollupConfigs( file: resolvePath(distDir, 'index.d.ts'), format: 'es', }, - external: [/\.css$/], + external: [ + /\.css$/, + /\.scss$/, + /\.sass$/, + /\.svg$/, + /\.eot$/, + /\.woff$/, + /\.woff2$/, + /\.ttf$/, + ], onwarn, plugins: [dts()], });