From 4a229328a5cc02357c830b61424fbecca9148592 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Tue, 16 Mar 2021 21:18:59 +0100 Subject: [PATCH] address comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .changeset/late-apples-doubt.md | 6 +++--- packages/integration-react/package.json | 2 +- .../src/ScmIntegrationsApi.ts | 19 ++++++++++++------- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/.changeset/late-apples-doubt.md b/.changeset/late-apples-doubt.md index f00ee76aad..f5d75ff5aa 100644 --- a/.changeset/late-apples-doubt.md +++ b/.changeset/late-apples-doubt.md @@ -1,7 +1,7 @@ --- -'@backstage/plugin-catalog': patch -'@backstage/plugin-catalog-import': patch -'@backstage/plugin-scaffolder': patch +'@backstage/plugin-catalog': minor +'@backstage/plugin-catalog-import': minor +'@backstage/plugin-scaffolder': minor --- Use `scmIntegrationsApiRef` from the new `@backstage/integration-react`. diff --git a/packages/integration-react/package.json b/packages/integration-react/package.json index d675be833a..9f33a25ac8 100644 --- a/packages/integration-react/package.json +++ b/packages/integration-react/package.json @@ -4,7 +4,7 @@ "main": "src/index.ts", "types": "src/index.ts", "license": "Apache-2.0", - "private": true, + "private": false, "publishConfig": { "access": "public", "main": "dist/index.esm.js", diff --git a/packages/integration-react/src/ScmIntegrationsApi.ts b/packages/integration-react/src/ScmIntegrationsApi.ts index 0494cd7aa8..507ecd8913 100644 --- a/packages/integration-react/src/ScmIntegrationsApi.ts +++ b/packages/integration-react/src/ScmIntegrationsApi.ts @@ -16,15 +16,20 @@ import { Config } from '@backstage/config'; import { ApiRef, createApiRef } from '@backstage/core'; -import { ScmIntegrations } from '@backstage/integration'; +import { + ScmIntegrationRegistry, + ScmIntegrations, +} from '@backstage/integration'; -export class ScmIntegrationsApi extends ScmIntegrations { - static fromConfig(config: Config): ScmIntegrationsApi { +export class ScmIntegrationsApi { + static fromConfig(config: Config): ScmIntegrationRegistry { return ScmIntegrations.fromConfig(config); } } -export const scmIntegrationsApiRef: ApiRef = createApiRef({ - id: 'integration.scmintegrations', - description: 'All of the registered SCM integrations of your config', -}); +export const scmIntegrationsApiRef: ApiRef = createApiRef( + { + id: 'integration.scmintegrations', + description: 'All of the registered SCM integrations of your config', + }, +);