From 2cd0b072b89b02d85c9441dfd6d84348cae9c823 Mon Sep 17 00:00:00 2001 From: Chris Gemmell Date: Thu, 19 Oct 2023 00:37:12 +1100 Subject: [PATCH 1/4] removing consent prompt Signed-off-by: Chris Gemmell --- .../auth-backend-module-microsoft-provider/src/authenticator.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/auth-backend-module-microsoft-provider/src/authenticator.ts b/plugins/auth-backend-module-microsoft-provider/src/authenticator.ts index bf2d7fcaba..ba1d75adf8 100644 --- a/plugins/auth-backend-module-microsoft-provider/src/authenticator.ts +++ b/plugins/auth-backend-module-microsoft-provider/src/authenticator.ts @@ -60,7 +60,6 @@ export const microsoftAuthenticator = createOAuthAuthenticator({ async start(input, helper) { return helper.start(input, { accessType: 'offline', - prompt: 'consent', }); }, From 2817115d09d508f35dac0588a7f314ec528b9de2 Mon Sep 17 00:00:00 2001 From: Chris Gemmell Date: Thu, 19 Oct 2023 00:42:28 +1100 Subject: [PATCH 2/4] added changeset Signed-off-by: Chris Gemmell --- .changeset/shiny-geese-watch.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/shiny-geese-watch.md diff --git a/.changeset/shiny-geese-watch.md b/.changeset/shiny-geese-watch.md new file mode 100644 index 0000000000..dfa7175f8c --- /dev/null +++ b/.changeset/shiny-geese-watch.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-auth-backend-module-microsoft-provider': patch +--- + +removed prompt=consent from start method to bugfix #20641 From 19b6c0ed2a40c0b4d622addcc4679f41f6fa47e5 Mon Sep 17 00:00:00 2001 From: Chris Gemmell Date: Thu, 19 Oct 2023 01:04:07 +1100 Subject: [PATCH 3/4] oops, forgot to change the module test Signed-off-by: Chris Gemmell --- .../auth-backend-module-microsoft-provider/src/module.test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/auth-backend-module-microsoft-provider/src/module.test.ts b/plugins/auth-backend-module-microsoft-provider/src/module.test.ts index ee7ed8f7f3..2cfedc5d5e 100644 --- a/plugins/auth-backend-module-microsoft-provider/src/module.test.ts +++ b/plugins/auth-backend-module-microsoft-provider/src/module.test.ts @@ -65,7 +65,6 @@ describe('authModuleMicrosoftProvider', () => { expect(startUrl.origin).toBe('https://login.microsoftonline.com'); expect(startUrl.pathname).toBe('/my-tenant-id/oauth2/v2.0/authorize'); expect(Object.fromEntries(startUrl.searchParams)).toEqual({ - prompt: 'consent', response_type: 'code', scope: 'user.read', client_id: 'my-client-id', From 0eab56d6d201e094127d8b885f576bc0dedab2f5 Mon Sep 17 00:00:00 2001 From: Andre Date: Wed, 18 Oct 2023 10:19:51 -0500 Subject: [PATCH 4/4] Cleaned up changeset Signed-off-by: Andre --- .changeset/shiny-geese-watch.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/shiny-geese-watch.md b/.changeset/shiny-geese-watch.md index dfa7175f8c..5394a0776d 100644 --- a/.changeset/shiny-geese-watch.md +++ b/.changeset/shiny-geese-watch.md @@ -2,4 +2,4 @@ '@backstage/plugin-auth-backend-module-microsoft-provider': patch --- -removed prompt=consent from start method to bugfix #20641 +Removed `prompt=consent` from start method to fix #20641