From 49261142a80a9202a5501e74fabc937911fbaf64 Mon Sep 17 00:00:00 2001 From: Yevhenii Huselietov Date: Wed, 11 Oct 2023 13:25:44 +0300 Subject: [PATCH] Fix review comments Signed-off-by: Yevhenii Huselietov --- .changeset/swift-kings-add.md | 2 +- .../DashboardSnapshotList/DashboardSnapshot.tsx | 2 +- .../DashboardSnapshotList/DashboardSnapshotList.tsx | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.changeset/swift-kings-add.md b/.changeset/swift-kings-add.md index cbbdb3877f..9e9c158eec 100644 --- a/.changeset/swift-kings-add.md +++ b/.changeset/swift-kings-add.md @@ -1,5 +1,5 @@ --- -'@backstage/plugin-newrelic-dashboard': minor +'@backstage/plugin-newrelic-dashboard': patch --- Fix the styles for NewRelicDashboard, add more responsiveness diff --git a/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardSnapshotList/DashboardSnapshot.tsx b/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardSnapshotList/DashboardSnapshot.tsx index 219b2ed925..c19697a4f0 100644 --- a/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardSnapshotList/DashboardSnapshot.tsx +++ b/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardSnapshotList/DashboardSnapshot.tsx @@ -31,7 +31,7 @@ import useObservable from 'react-use/lib/useObservable'; const useStyles = makeStyles( theme => ({ cardSelect: { - margin: '15px 10px 0 0', + margin: theme.spacing(2, 1, 0, 0), }, img: { width: '100%', diff --git a/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardSnapshotList/DashboardSnapshotList.tsx b/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardSnapshotList/DashboardSnapshotList.tsx index 610ebbfce9..81686d10c9 100644 --- a/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardSnapshotList/DashboardSnapshotList.tsx +++ b/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardSnapshotList/DashboardSnapshotList.tsx @@ -30,11 +30,11 @@ interface TabPanelProps { } const tabPanelStyles = makeStyles( - { + theme => ({ tabPanel: { - marginTop: '4px', + marginTop: theme.spacing(0.5), }, - }, + }), { name: 'BackstageNewRelicDashboardTabPanel' }, );