From 4925d4e768b4eb79f9bcb2e39fe81847dd7cb6a1 Mon Sep 17 00:00:00 2001 From: blam Date: Tue, 5 Jan 2021 16:50:54 +0100 Subject: [PATCH] chore: tidy up some smaller parts of the modal to align with the ADR --- .../scaffolder/src/components/JobStage/JobStage.tsx | 2 +- .../scaffolder/src/components/JobStage/LogModal.tsx | 11 +---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/plugins/scaffolder/src/components/JobStage/JobStage.tsx b/plugins/scaffolder/src/components/JobStage/JobStage.tsx index 53ceffc87d..86c2982dde 100644 --- a/plugins/scaffolder/src/components/JobStage/JobStage.tsx +++ b/plugins/scaffolder/src/components/JobStage/JobStage.tsx @@ -31,9 +31,9 @@ import ExpandLessIcon from '@material-ui/icons/ExpandLess'; import cn from 'classnames'; import moment from 'moment'; import React, { Suspense, useEffect, useState } from 'react'; +import { LogModal } from './LogModal'; import { Job } from '../../types'; -const LogModal = React.lazy(() => import('./LogModal')); const LazyLog = React.lazy(() => import('react-lazylog/build/LazyLog')); moment.relativeTimeThreshold('ss', 0); diff --git a/plugins/scaffolder/src/components/JobStage/LogModal.tsx b/plugins/scaffolder/src/components/JobStage/LogModal.tsx index 8c2d757ade..73b6253510 100644 --- a/plugins/scaffolder/src/components/JobStage/LogModal.tsx +++ b/plugins/scaffolder/src/components/JobStage/LogModal.tsx @@ -46,15 +46,7 @@ const useStyles = makeStyles(theme => ({ }, })); -export const LogModal = ({ - log, - open = false, - onClose, -}: { - log: string[]; - open: boolean; - onClose: () => void; -}) => { +export const LogModal = ({ log, open = false, onClose }: Props) => { const classes = useStyles(); return ( @@ -73,4 +65,3 @@ export const LogModal = ({ ); }; -export default LogModal;