From 4907da392ae556fef1732ebce8dc041d9494d2ba Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Mon, 8 Sep 2025 10:28:06 +0200
Subject: [PATCH] frontend-test-utils: updated to use and report errors via
 error collector

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../src/wiring/createExtension.test.ts          |  8 ++++----
 .../src/app/createExtensionTester.tsx           | 17 ++++++++++++++++-
 2 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/packages/frontend-plugin-api/src/wiring/createExtension.test.ts b/packages/frontend-plugin-api/src/wiring/createExtension.test.ts
index 00dd981e26..59a81f1b59 100644
--- a/packages/frontend-plugin-api/src/wiring/createExtension.test.ts
+++ b/packages/frontend-plugin-api/src/wiring/createExtension.test.ts
@@ -1078,7 +1078,7 @@ describe('createExtension', () => {
           .add(multi2Ext)
           .get(outputRef),
       ).toThrowErrorMatchingInlineSnapshot(
-        `"Failed to instantiate extension 'subject', override data provided for input 'multi' must match the length of the original inputs"`,
+        `"Failed to resolve the extension tree: Failed to instantiate extension 'subject', override data provided for input 'multi' must match the length of the original inputs"`,
       );
 
       // Mix forward and data override
@@ -1101,7 +1101,7 @@ describe('createExtension', () => {
           .add(multi2Ext)
           .get(outputRef),
       ).toThrowErrorMatchingInlineSnapshot(
-        `"Failed to instantiate extension 'subject', override data for input 'multi' may not mix forwarded inputs with data overrides"`,
+        `"Failed to resolve the extension tree: Failed to instantiate extension 'subject', override data for input 'multi' may not mix forwarded inputs with data overrides"`,
       );
 
       // Required input not provided
@@ -1124,7 +1124,7 @@ describe('createExtension', () => {
           .add(multi2Ext)
           .get(outputRef),
       ).toThrowErrorMatchingInlineSnapshot(
-        `"Failed to instantiate extension 'subject', missing required extension data value(s) 'test1'"`,
+        `"Failed to resolve the extension tree: Failed to instantiate extension 'subject', missing required extension data value(s) 'test1'"`,
       );
 
       // Wrong value provided
@@ -1153,7 +1153,7 @@ describe('createExtension', () => {
           .add(multi2Ext)
           .get(outputRef),
       ).toThrowErrorMatchingInlineSnapshot(
-        `"Failed to instantiate extension 'subject', extension data 'test2' was provided but not declared"`,
+        `"Failed to resolve the extension tree: Failed to instantiate extension 'subject', extension data 'test2' was provided but not declared"`,
       );
     });
   });
diff --git a/packages/frontend-test-utils/src/app/createExtensionTester.tsx b/packages/frontend-test-utils/src/app/createExtensionTester.tsx
index 7b321d4413..50d65fddc7 100644
--- a/packages/frontend-test-utils/src/app/createExtensionTester.tsx
+++ b/packages/frontend-test-utils/src/app/createExtensionTester.tsx
@@ -35,6 +35,8 @@ import { resolveAppNodeSpecs } from '../../../frontend-app-api/src/tree/resolveA
 import { instantiateAppNodeTree } from '../../../frontend-app-api/src/tree/instantiateAppNodeTree';
 // eslint-disable-next-line @backstage/no-relative-monorepo-imports
 import { readAppExtensionsConfig } from '../../../frontend-app-api/src/tree/readAppExtensionsConfig';
+// eslint-disable-next-line @backstage/no-relative-monorepo-imports
+import { createErrorCollector } from '../../../frontend-app-api/src/wiring/createErrorCollector';
 import { TestApiRegistry } from '@backstage/test-utils';
 import { OpaqueExtensionDefinition } from '@internal/frontend';
 
@@ -191,16 +193,29 @@ export class ExtensionTester<UOutput extends ExtensionDataRef> {
       );
     }
 
+    const collector = createErrorCollector();
+
     const tree = resolveAppTree(
       subject.id,
       resolveAppNodeSpecs({
         features: [],
         builtinExtensions: this.#extensions.map(_ => _.extension),
         parameters: readAppExtensionsConfig(this.#getConfig()),
+        collector,
       }),
+      collector,
     );
 
-    instantiateAppNodeTree(tree.root, TestApiRegistry.from());
+    instantiateAppNodeTree(tree.root, TestApiRegistry.from(), collector);
+
+    const errors = collector.collectErrors();
+    if (errors) {
+      throw new Error(
+        `Failed to resolve the extension tree: ${errors
+          .map(e => e.message)
+          .join(', ')}`,
+      );
+    }
 
     this.#tree = tree;