From af7f25dec73059a195722e81b8cc0d0430202fd8 Mon Sep 17 00:00:00 2001 From: "Stephen A. Wilson" Date: Thu, 22 Feb 2024 11:33:57 -0500 Subject: [PATCH 1/4] Add .ico to assets transformer Allows for import .ico files as assets Signed-off-by: Stephen A. Wilson --- packages/cli/src/lib/bundler/transforms.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/cli/src/lib/bundler/transforms.ts b/packages/cli/src/lib/bundler/transforms.ts index e0308f5c2d..da1eec4e11 100644 --- a/packages/cli/src/lib/bundler/transforms.ts +++ b/packages/cli/src/lib/bundler/transforms.ts @@ -145,6 +145,7 @@ export const transforms = (options: TransformOptions): Transforms => { /\.vert$/, { and: [/\.svg$/, { not: [/\.icon\.svg$/] }] }, /\.xml$/, + /\.ico$/, ], type: 'asset/resource', generator: { From 472bf729c67123e0077789f8c3b29f6011735191 Mon Sep 17 00:00:00 2001 From: "Stephen A. Wilson" Date: Thu, 22 Feb 2024 12:11:32 -0500 Subject: [PATCH 2/4] add .ico to asset-types.d.ts Signed-off-by: Stephen A. Wilson --- packages/cli/asset-types/asset-types.d.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/cli/asset-types/asset-types.d.ts b/packages/cli/asset-types/asset-types.d.ts index 2d288fd0e3..5328a84522 100644 --- a/packages/cli/asset-types/asset-types.d.ts +++ b/packages/cli/asset-types/asset-types.d.ts @@ -55,6 +55,11 @@ declare module '*.webp' { export default src; } +declare module '*.ico' { + const src: string; + export default src; +} + declare module '*.yaml' { const src: string; export default src; From f4404e5ca327473083d4f6ce5f049658866dd4a7 Mon Sep 17 00:00:00 2001 From: "Stephen A. Wilson" Date: Thu, 22 Feb 2024 12:53:29 -0500 Subject: [PATCH 3/4] add changeset Signed-off-by: Stephen A. Wilson --- .changeset/slimy-trainers-attend.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/slimy-trainers-attend.md diff --git a/.changeset/slimy-trainers-attend.md b/.changeset/slimy-trainers-attend.md new file mode 100644 index 0000000000..43b2b807be --- /dev/null +++ b/.changeset/slimy-trainers-attend.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Add .ico import support From f4c08bb6712e18338159fa7e7337f87c996db823 Mon Sep 17 00:00:00 2001 From: "Stephen A. Wilson" Date: Fri, 23 Feb 2024 12:33:03 -0500 Subject: [PATCH 4/4] Add ico extension to jest Signed-off-by: Stephen A. Wilson --- packages/cli/config/jest.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/config/jest.js b/packages/cli/config/jest.js index 584a31c672..6d7b2bf038 100644 --- a/packages/cli/config/jest.js +++ b/packages/cli/config/jest.js @@ -185,7 +185,7 @@ async function getProjectConfig(targetPath, extraConfig) { }, }, ], - '\\.(bmp|gif|jpg|jpeg|png|frag|xml|svg|eot|woff|woff2|ttf)$': + '\\.(bmp|gif|jpg|jpeg|png|ico|frag|xml|svg|eot|woff|woff2|ttf)$': require.resolve('./jestFileTransform.js'), '\\.(yaml)$': require.resolve('./jestYamlTransform'), },