From f294967b480d146598ae5c56f03404bb7b23d807 Mon Sep 17 00:00:00 2001 From: "mattheus.henrique" Date: Mon, 1 May 2023 01:31:15 -0300 Subject: [PATCH 1/3] docs(apollo-explorer-README): Add snippet with import Signed-off-by: MattheusHenrique --- plugins/apollo-explorer/README.md | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/plugins/apollo-explorer/README.md b/plugins/apollo-explorer/README.md index 98f3116966..97f53485be 100644 --- a/plugins/apollo-explorer/README.md +++ b/plugins/apollo-explorer/README.md @@ -38,17 +38,25 @@ yarn --cwd packages/app add @backstage/plugin-apollo-explorer Then, in `packages/app/src/App.tsx` add the plugin as a `Route` ```typescript - + {/* other tabs... */} + + } /> - } -/> ``` Then, in `packages/app/src/components/Root/Root.tsx` add a sidebar item so users can find your beautiful plugin! From 172251b8dbe64d6ee6aa4bd04da14abf117b43cc Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 4 May 2023 11:43:51 +0200 Subject: [PATCH 2/3] Apply suggestions from code review Signed-off-by: Patrik Oldsberg --- plugins/apollo-explorer/README.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/plugins/apollo-explorer/README.md b/plugins/apollo-explorer/README.md index 97f53485be..1876cd03be 100644 --- a/plugins/apollo-explorer/README.md +++ b/plugins/apollo-explorer/README.md @@ -38,14 +38,10 @@ yarn --cwd packages/app add @backstage/plugin-apollo-explorer Then, in `packages/app/src/App.tsx` add the plugin as a `Route` ```typescript -// In packages/app/src/App.tsx import { ApolloExplorerPage } from '@backstage/plugin-apollo-explorer'; - -// You can add the tab to any number of pages, the service page is shown as an -// example here const routes = ( - {/* other tabs... */} + {/* other routes... */} Date: Thu, 4 May 2023 11:44:14 +0200 Subject: [PATCH 3/3] Update plugins/apollo-explorer/README.md Signed-off-by: Patrik Oldsberg --- plugins/apollo-explorer/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/apollo-explorer/README.md b/plugins/apollo-explorer/README.md index 1876cd03be..23ea71e934 100644 --- a/plugins/apollo-explorer/README.md +++ b/plugins/apollo-explorer/README.md @@ -39,6 +39,7 @@ Then, in `packages/app/src/App.tsx` add the plugin as a `Route` ```typescript import { ApolloExplorerPage } from '@backstage/plugin-apollo-explorer'; + const routes = ( {/* other routes... */}