Fix creating secrets in github:environment:create action

Signed-off-by: Kamil Markow <kamilmarkow@gmail.com>
This commit is contained in:
Kamil Markow
2023-11-17 12:36:47 -05:00
parent 998850c368
commit 48667b4d3a
4 changed files with 14 additions and 9 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-scaffolder-backend': patch
---
Fix creating env secret in github:environment:create action
@@ -25,7 +25,7 @@ import { examples } from './gitHubEnvironment.examples';
const mockOctokit = {
rest: {
actions: {
getRepoPublicKey: jest.fn(),
getEnvironmentPublicKey: jest.fn(),
createEnvironmentVariable: jest.fn(),
createOrUpdateEnvironmentSecret: jest.fn(),
},
@@ -68,7 +68,7 @@ describe('github:environment:create examples', () => {
};
beforeEach(() => {
mockOctokit.rest.actions.getRepoPublicKey.mockResolvedValue({
mockOctokit.rest.actions.getEnvironmentPublicKey.mockResolvedValue({
data: {
key: publicKey,
key_id: 'keyid',
@@ -109,7 +109,7 @@ describe('github:environment:create examples', () => {
expect(
mockOctokit.rest.actions.createEnvironmentVariable,
).not.toHaveBeenCalled();
expect(mockOctokit.rest.actions.getRepoPublicKey).not.toHaveBeenCalled();
expect(mockOctokit.rest.actions.getEnvironmentPublicKey).not.toHaveBeenCalled();
expect(
mockOctokit.rest.actions.createOrUpdateEnvironmentSecret,
).not.toHaveBeenCalled();
@@ -141,7 +141,7 @@ describe('github:environment:create examples', () => {
expect(
mockOctokit.rest.actions.createEnvironmentVariable,
).not.toHaveBeenCalled();
expect(mockOctokit.rest.actions.getRepoPublicKey).not.toHaveBeenCalled();
expect(mockOctokit.rest.actions.getEnvironmentPublicKey).not.toHaveBeenCalled();
expect(
mockOctokit.rest.actions.createOrUpdateEnvironmentSecret,
).not.toHaveBeenCalled();
@@ -24,7 +24,7 @@ import { ScmIntegrations } from '@backstage/integration';
const mockOctokit = {
rest: {
actions: {
getRepoPublicKey: jest.fn(),
getEnvironmentPublicKey: jest.fn(),
createEnvironmentVariable: jest.fn(),
createOrUpdateEnvironmentSecret: jest.fn(),
},
@@ -71,7 +71,7 @@ describe('github:environment:create', () => {
};
beforeEach(() => {
mockOctokit.rest.actions.getRepoPublicKey.mockResolvedValue({
mockOctokit.rest.actions.getEnvironmentPublicKey.mockResolvedValue({
data: {
key: publicKey,
key_id: 'keyid',
@@ -167,9 +167,9 @@ export function createGithubEnvironmentAction(options: {
}
if (secrets) {
const publicKeyResponse = await client.rest.actions.getRepoPublicKey({
owner: owner,
repo: repo,
const publicKeyResponse = await client.rest.actions.getEnvironmentPublicKey({
repository_id: repository.data.id,
environment_name: name,
});
await Sodium.ready;