From 47d246691ac11ca2da2c27687173f89344c3b9d0 Mon Sep 17 00:00:00 2001
From: Mark David Avery <mark@webark.cc>
Date: Thu, 16 Feb 2023 20:40:13 -0800
Subject: [PATCH] fix(plugin-entity-validation): using location for the value
 rather than default location

Fixes #16406

Signed-off-by: Mark David Avery <mark@webark.cc>
---
 .changeset/khaki-poems-run.md                 |  5 +++++
 plugins/entity-validation/dev/index.tsx       |  9 +++++++++
 .../EntityValidationPage.tsx                  | 19 +++++++------------
 3 files changed, 21 insertions(+), 12 deletions(-)
 create mode 100644 .changeset/khaki-poems-run.md

diff --git a/.changeset/khaki-poems-run.md b/.changeset/khaki-poems-run.md
new file mode 100644
index 0000000000..74db902c02
--- /dev/null
+++ b/.changeset/khaki-poems-run.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-entity-validation': patch
+---
+
+Fixed bug in EntityVaidation plugin where string in text box was unable to be updated.
diff --git a/plugins/entity-validation/dev/index.tsx b/plugins/entity-validation/dev/index.tsx
index 1e1dfa760c..42f4b152ed 100644
--- a/plugins/entity-validation/dev/index.tsx
+++ b/plugins/entity-validation/dev/index.tsx
@@ -16,9 +16,18 @@
 import React from 'react';
 import { createDevApp } from '@backstage/dev-utils';
 import { entityValidationPlugin, EntityValidationPage } from '../src/plugin';
+import { CatalogApi, catalogApiRef } from '@backstage/plugin-catalog-react';
 
 createDevApp()
   .registerPlugin(entityValidationPlugin)
+  .registerApi({
+    api: catalogApiRef,
+    deps: {},
+    factory: () =>
+      ({
+        getEntities: () => ({}),
+      } as CatalogApi),
+  })
   .addPage({
     element: <EntityValidationPage />,
     title: 'Root Page',
diff --git a/plugins/entity-validation/src/components/EntityValidationPage/EntityValidationPage.tsx b/plugins/entity-validation/src/components/EntityValidationPage/EntityValidationPage.tsx
index dc86af8763..52628e6ad2 100644
--- a/plugins/entity-validation/src/components/EntityValidationPage/EntityValidationPage.tsx
+++ b/plugins/entity-validation/src/components/EntityValidationPage/EntityValidationPage.tsx
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 import React, { useState } from 'react';
-import { Button, Content, Header, Page } from '@backstage/core-components';
+import { Content, Header, LinkButton, Page } from '@backstage/core-components';
 import { EntityTextArea } from '../EntityTextArea';
 import { Grid, TextField } from '@material-ui/core';
 import { CatalogProcessorResult } from '../../types';
@@ -47,7 +47,7 @@ export const EntityValidationPage = (props: {
 
   const [catalogYaml, setCatalogYaml] = useState(defaultYaml);
   const [yamlFiles, setYamlFiles] = useState<CatalogProcessorResult[]>();
-  const [locationUrl, setLocationUrl] = useState('');
+  const [locationUrl, setLocationUrl] = useState(defaultLocation);
 
   const parseYaml = () => {
     const parsedFiles = [
@@ -66,15 +66,15 @@ export const EntityValidationPage = (props: {
         subtitle="Tool to validate catalog-info.yaml files"
       />
       <Content>
-        <Grid container direction="row">
+        <Grid container>
           <Grid item md={9} xs={12}>
             <TextField
-              style={{ width: '100%' }}
+              fullWidth
               label="File Location"
               margin="normal"
               variant="outlined"
               required
-              value={defaultLocation}
+              value={locationUrl}
               placeholder={defaultLocation}
               helperText="Location where you catalog-info.yaml file is, or will be, located"
               onChange={e => setLocationUrl(e.target.value)}
@@ -83,14 +83,9 @@ export const EntityValidationPage = (props: {
           <Grid item md={3} xs={12}>
             <Grid container alignItems="center" style={{ height: '100%' }}>
               <Grid item>
-                <Button
-                  style={{ textDecoration: 'none' }}
-                  variant="outlined"
-                  to="#"
-                  onClick={parseYaml}
-                >
+                <LinkButton size="large" onClick={parseYaml} to="#">
                   Validate
-                </Button>
+                </LinkButton>
               </Grid>
             </Grid>
           </Grid>