paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 31 Packages Projects Releases Wiki Activity

Merge pull request #17780 from XpiritBV/support-azdo-identities

Browse Source 
feat(azure): support service principals and managed identities
This commit is contained in:
Ben Lambert
2023-05-29 12:44:15 +02:00
committed by GitHub
parent b50bfd6610 c7f848bcea
commit 47c974e22b
12 changed files with 436 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/backend-common/src/reading/AzureUrlReader.ts
+4 -4
View File
@@ -76,7 +76,7 @@ export class AzureUrlReader implements UrlReader {
let response: Response;
try {
response = await fetch(builtUrl, {
...getAzureRequestOptions(this.integration.config),
...(await getAzureRequestOptions(this.integration.config)),
// TODO(freben): The signal cast is there because pre-3.x versions of
// node-fetch have a very slightly deviating AbortSignal type signature.
// The difference does not affect us in practice however. The cast can
@@ -113,7 +113,7 @@ export class AzureUrlReader implements UrlReader {
const commitsAzureResponse = await fetch(
getAzureCommitsUrl(url),
getAzureRequestOptions(this.integration.config),
await getAzureRequestOptions(this.integration.config),
);
if (!commitsAzureResponse.ok) {
const message = `Failed to read tree from ${url}, ${commitsAzureResponse.status} ${commitsAzureResponse.statusText}`;
@@ -129,9 +129,9 @@ export class AzureUrlReader implements UrlReader {
}
const archiveAzureResponse = await fetch(getAzureDownloadUrl(url), {
...getAzureRequestOptions(this.integration.config, {
...(await getAzureRequestOptions(this.integration.config, {
Accept: 'application/zip',
}),
})),
// TODO(freben): The signal cast is there because pre-3.x versions of
// node-fetch have a very slightly deviating AbortSignal type signature.
// The difference does not affect us in practice however. The cast can be