From 47aea432092261f65b68e9a14471f275002f9b82 Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 14 Oct 2024 11:17:22 +0200 Subject: [PATCH] chore: cleanup app-next a little bit Signed-off-by: blam --- packages/app-next/src/App.tsx | 32 ----------------- .../app-next/src/overrides/SignInPage.tsx | 35 ------------------- 2 files changed, 67 deletions(-) delete mode 100644 packages/app-next/src/overrides/SignInPage.tsx diff --git a/packages/app-next/src/App.tsx b/packages/app-next/src/App.tsx index 79adc13daf..1992d5b35f 100644 --- a/packages/app-next/src/App.tsx +++ b/packages/app-next/src/App.tsx @@ -26,7 +26,6 @@ import homePlugin, { import { coreExtensionData, createExtension, - ApiBlueprint, createFrontendModule, } from '@backstage/frontend-plugin-api'; import { @@ -41,14 +40,7 @@ import { convertLegacyApp } from '@backstage/core-compat-api'; import { FlatRoutes } from '@backstage/core-app-api'; import { Route } from 'react-router'; import { CatalogImportPage } from '@backstage/plugin-catalog-import'; -import { createApiFactory, configApiRef } from '@backstage/core-plugin-api'; -import { - ScmAuth, - ScmIntegrationsApi, - scmIntegrationsApiRef, -} from '@backstage/integration-react'; import kubernetesPlugin from '@backstage/plugin-kubernetes/alpha'; -import { signInPageModule } from './overrides/SignInPage'; import { convertLegacyPlugin } from '@backstage/core-compat-api'; import { convertLegacyPageExtension } from '@backstage/core-compat-api'; import { convertLegacyEntityContentExtension } from '@backstage/plugin-catalog-react/alpha'; @@ -118,28 +110,6 @@ const customHomePageModule = createFrontendModule({ ], }); -const scmModule = createFrontendModule({ - pluginId: 'app', - extensions: [ - ApiBlueprint.make({ - name: 'scm-auth', - params: { - factory: ScmAuth.createDefaultApiFactory(), - }, - }), - ApiBlueprint.make({ - name: 'scm-integrations', - params: { - factory: createApiFactory({ - api: scmIntegrationsApiRef, - deps: { configApi: configApiRef }, - factory: ({ configApi }) => ScmIntegrationsApi.fromConfig(configApi), - }), - }, - }), - ], -}); - const notFoundErrorPageModule = createFrontendModule({ pluginId: 'app', extensions: [notFoundErrorPage], @@ -159,8 +129,6 @@ const app = createApp({ homePlugin, appVisualizerPlugin, kubernetesPlugin, - signInPageModule, - scmModule, notFoundErrorPageModule, customHomePageModule, ...collectedLegacyPlugins, diff --git a/packages/app-next/src/overrides/SignInPage.tsx b/packages/app-next/src/overrides/SignInPage.tsx deleted file mode 100644 index f1e37a241b..0000000000 --- a/packages/app-next/src/overrides/SignInPage.tsx +++ /dev/null @@ -1,35 +0,0 @@ -/* - * Copyright 2024 The Backstage Authors - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -import React from 'react'; -import { SignInPage } from '@backstage/core-components'; -import { - SignInPageBlueprint, - createFrontendModule, -} from '@backstage/frontend-plugin-api'; - -const signInPage = SignInPageBlueprint.make({ - name: 'guest', - params: { - loader: async () => props => - , - }, -}); - -export const signInPageModule = createFrontendModule({ - pluginId: 'app', - extensions: [signInPage], -});