From 4780af8e153de5686c61b3cda58da5c7b73d227f Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Fri, 12 Jan 2024 17:49:22 +0100
Subject: [PATCH] frontend-app-api: list candidate inputs in undeclared input
 warning

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../src/tree/instantiateAppNodeTree.test.ts      |  6 +++---
 .../src/tree/instantiateAppNodeTree.ts           | 16 +++++++++++-----
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/packages/frontend-app-api/src/tree/instantiateAppNodeTree.test.ts b/packages/frontend-app-api/src/tree/instantiateAppNodeTree.test.ts
index ec8712cf59..766cb4804e 100644
--- a/packages/frontend-app-api/src/tree/instantiateAppNodeTree.test.ts
+++ b/packages/frontend-app-api/src/tree/instantiateAppNodeTree.test.ts
@@ -475,7 +475,7 @@ describe('createAppNodeInstance', () => {
     );
 
     expect(warn).toEqual([
-      "The extension 'app/test' is attached to the input 'undeclared' of 'app/parent', but the extension 'app/parent' noes not declare a 'undeclared' input",
+      "The extension 'app/test' is attached to the input 'undeclared' of the extension 'app/parent', but it has no such input (candidates are 'declared')",
     ]);
   });
 
@@ -510,8 +510,8 @@ describe('createAppNodeInstance', () => {
     );
 
     expect(warn).toEqual([
-      "The extension 'app/test' is attached to the input 'undeclared1' of 'app/parent', but the extension 'app/parent' noes not declare a 'undeclared1' input",
-      "The extensions 'app/test', 'app/test' are attached to the input 'undeclared2' of 'app/parent', but the extension 'app/parent' noes not declare a 'undeclared2' input",
+      "The extension 'app/test' is attached to the input 'undeclared1' of the extension 'app/parent', but it has no inputs",
+      "The extensions 'app/test', 'app/test' are attached to the input 'undeclared2' of the extension 'app/parent', but it has no inputs",
     ]);
   });
 
diff --git a/packages/frontend-app-api/src/tree/instantiateAppNodeTree.ts b/packages/frontend-app-api/src/tree/instantiateAppNodeTree.ts
index b1fa9eae39..90a256fea6 100644
--- a/packages/frontend-app-api/src/tree/instantiateAppNodeTree.ts
+++ b/packages/frontend-app-api/src/tree/instantiateAppNodeTree.ts
@@ -55,15 +55,21 @@ function resolveInputs(
   );
 
   if (process.env.NODE_ENV !== 'production') {
+    const inputNames = Object.keys(inputMap);
+
     for (const [name, nodes] of undeclaredAttachments) {
       const pl = nodes.length > 1;
       // eslint-disable-next-line no-console
       console.warn(
-        `The extension${pl ? 's' : ''} '${nodes
-          .map(n => n.spec.id)
-          .join("', '")}' ${
-          pl ? 'are' : 'is'
-        } attached to the input '${name}' of '${id}', but the extension '${id}' noes not declare a '${name}' input`,
+        [
+          `The extension${pl ? 's' : ''} '${nodes
+            .map(n => n.spec.id)
+            .join("', '")}' ${pl ? 'are' : 'is'}`,
+          `attached to the input '${name}' of the extension '${id}', but it`,
+          inputNames.length === 0
+            ? 'has no inputs'
+            : `has no such input (candidates are '${inputNames.join("', '")}')`,
+        ].join(' '),
       );
     }
   }