From 465dffb05c704d8922acd2ea58383b357be93a41 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Wed, 10 Nov 2021 11:48:52 +0100
Subject: [PATCH] core-app-api,app-defaults: API report and doc fixups

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 packages/app-defaults/api-report.md                    | 4 ++--
 packages/core-app-api/api-report.md                    | 9 ++-------
 packages/core-app-api/src/app/createApp.tsx            | 2 +-
 packages/core-app-api/src/app/createSpecializedApp.tsx | 1 +
 4 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/packages/app-defaults/api-report.md b/packages/app-defaults/api-report.md
index 6b35dab81b..57ea61ad8b 100644
--- a/packages/app-defaults/api-report.md
+++ b/packages/app-defaults/api-report.md
@@ -5,15 +5,15 @@
 ```ts
 import { AppComponents } from '@backstage/core-app-api';
 import { AppIcons } from '@backstage/core-app-api';
-import { AppManager } from '@backstage/core-app-api/src/app/AppManager';
 import { AppOptions } from '@backstage/core-app-api';
 import { AppTheme } from '@backstage/core-plugin-api';
+import { BackstageApp } from '@backstage/core-app-api';
 import { IconComponent } from '@backstage/core-plugin-api';
 
 // @public
 export function createApp(
   options?: Omit<AppOptions, keyof OptionalAppOptions> & OptionalAppOptions,
-): AppManager;
+): BackstageApp;
 
 // @public
 export type OptionalAppOptions = {
diff --git a/packages/core-app-api/api-report.md b/packages/core-app-api/api-report.md
index f45fc349b2..d98b5ef5f8 100644
--- a/packages/core-app-api/api-report.md
+++ b/packages/core-app-api/api-report.md
@@ -313,16 +313,11 @@ export type BootErrorPageProps = {
 
 export { ConfigReader };
 
-// Warning: (tsdoc-characters-after-block-tag) The token "@backstage" looks like a TSDoc tag but contains an invalid character "/"; if it is not a tag, use a backslash to escape the "@"
-// Warning: (ae-forgotten-export) The symbol "AppManager" needs to be exported by the entry point index.d.ts
-//
 // @public @deprecated
-export function createApp(options?: OptionalAppOptions): AppManager;
+export function createApp(options?: OptionalAppOptions): BackstageApp;
 
-// Warning: (ae-missing-release-tag) "createSpecializedApp" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
-//
 // @public
-export function createSpecializedApp(options: AppOptions): AppManager;
+export function createSpecializedApp(options: AppOptions): BackstageApp;
 
 // @public
 export const defaultConfigLoader: AppConfigLoader;
diff --git a/packages/core-app-api/src/app/createApp.tsx b/packages/core-app-api/src/app/createApp.tsx
index a020308d91..e11076099b 100644
--- a/packages/core-app-api/src/app/createApp.tsx
+++ b/packages/core-app-api/src/app/createApp.tsx
@@ -22,7 +22,7 @@ import {
 /**
  * Creates a new Backstage App.
  *
- * @deprecated Use createApp from @backstage/app-defaults instead
+ * @deprecated Use {@link @backstage/app-defaults#createApp} from `@backstage/app-defaults` instead
  * @param options - A set of options for creating the app
  * @public
  */
diff --git a/packages/core-app-api/src/app/createSpecializedApp.tsx b/packages/core-app-api/src/app/createSpecializedApp.tsx
index a437835f39..9bda223722 100644
--- a/packages/core-app-api/src/app/createSpecializedApp.tsx
+++ b/packages/core-app-api/src/app/createSpecializedApp.tsx
@@ -20,6 +20,7 @@ import { AppOptions, BackstageApp } from './types';
 /**
  * Creates a new Backstage App where the full set of options are required.
  *
+ * @public
  * @param options - A set of options for creating the app
  * @returns
  */