From 268b8634f9e02009f183ef6b8a007cfe9d32368e Mon Sep 17 00:00:00 2001 From: Rogerio Angeliski Date: Fri, 6 Jan 2023 19:03:00 +0000 Subject: [PATCH] feat(scaffolder-backend-module-rails) add skipActiveRecord argument Co-authored-by: Guilherme Co-authored-by: Daniela Co-authored-by: Sarah Signed-off-by: Rogerio Angeliski --- .changeset/chatty-moose-matter.md | 5 +++++ .../src/actions/fetch/rails/index.ts | 6 ++++++ .../src/actions/fetch/rails/railsArgumentResolver.test.ts | 1 + .../src/actions/fetch/rails/railsArgumentResolver.ts | 5 +++++ 4 files changed, 17 insertions(+) create mode 100644 .changeset/chatty-moose-matter.md diff --git a/.changeset/chatty-moose-matter.md b/.changeset/chatty-moose-matter.md new file mode 100644 index 0000000000..35f73e690a --- /dev/null +++ b/.changeset/chatty-moose-matter.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-backend-module-rails': patch +--- + +handle skipActiveRecord rails new argument diff --git a/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/index.ts b/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/index.ts index 7a77470e9b..4a5bd7dfd1 100644 --- a/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/index.ts +++ b/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/index.ts @@ -128,6 +128,12 @@ export function createFetchRailsAction(options: { description: 'Skip Action Text gem', type: 'boolean', }, + skipActiveRecord: { + title: 'skipActiveRecord', + description: 'Skip Active Record files', + type: 'boolean', + }, + force: { title: 'force', description: 'Overwrite files that already exist', diff --git a/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.test.ts b/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.test.ts index 401ebb295f..935c8f96bd 100644 --- a/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.test.ts +++ b/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.test.ts @@ -33,6 +33,7 @@ describe('railsArgumentResolver', () => { [{ skipActionMailbox: true }, ['--skip-action-mailbox']], [{ skipActiveStorage: true }, ['--skip-active-storage']], [{ skipActionText: true }, ['--skip-action-text']], + [{ skipActiveRecord: true }, ['--skip-active-record']], [{ force: true }, ['--force']], [{ webpacker: 'vue' }, ['--webpack', 'vue']], [{ database: 'postgresql' }, ['--database', 'postgresql']], diff --git a/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.ts b/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.ts index 666eac7958..bcfc8cc487 100644 --- a/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.ts +++ b/plugins/scaffolder-backend-module-rails/src/actions/fetch/rails/railsArgumentResolver.ts @@ -57,6 +57,7 @@ export type RailsRunOptions = { skipBundle?: boolean; skipTest?: boolean; skipWebpackInstall?: boolean; + skipActiveRecord?: boolean; template?: string; webpacker?: Webpacker; }; @@ -84,6 +85,10 @@ export const railsArgumentResolver = ( argumentsToRun.push('--skip-webpack-install'); } + if (options?.skipActiveRecord) { + argumentsToRun.push('--skip-active-record'); + } + if (options?.skipTest) { argumentsToRun.push('--skip-test'); }