address pr review feedback

Signed-off-by: John Collier <jcollier@redhat.com>
2026-03-05 10:54:33 -05:00
parent f5fb2829f7
commit 4445d88cff
3 changed files with 72 additions and 24 deletions
@@ -202,4 +202,61 @@ describe('scaffolderServiceRef', () => {

    expect(result).toEqual({ items: [], totalItems: 0 });
  });
+
+  it('should serialize a single status as a repeated query param for listTasks', async () => {
+    expect.assertions(1);
+
+    server.use(
+      rest.get('*/api/scaffolder/v2/tasks', (req, res, ctx) => {
+        expect(req.url.searchParams.getAll('status')).toEqual(['completed']);
+        return res(ctx.json({ tasks: [], totalTasks: 0 }));
+      }),
+    );
+
+    const tester = ServiceFactoryTester.from(
+      createServiceFactory({
+        service: createServiceRef<void>({ id: 'unused-dummy' }),
+        deps: {},
+        factory() {},
+      }),
+      { dependencies: [mockServices.discovery.factory()] },
+    );
+
+    const scaffolder = await tester.getService(scaffolderServiceRef);
+
+    await scaffolder.listTasks(
+      { status: 'completed' },
+      { credentials: mockCredentials.user() },
+    );
+  });
+
+  it('should serialize multiple statuses as repeated query params for listTasks', async () => {
+    expect.assertions(1);
+
+    server.use(
+      rest.get('*/api/scaffolder/v2/tasks', (req, res, ctx) => {
+        expect(req.url.searchParams.getAll('status')).toEqual([
+          'completed',
+          'failed',
+        ]);
+        return res(ctx.json({ tasks: [], totalTasks: 0 }));
+      }),
+    );
+
+    const tester = ServiceFactoryTester.from(
+      createServiceFactory({
+        service: createServiceRef<void>({ id: 'unused-dummy' }),
+        deps: {},
+        factory() {},
+      }),
+      { dependencies: [mockServices.discovery.factory()] },
+    );
+
+    const scaffolder = await tester.getService(scaffolderServiceRef);
+
+    await scaffolder.listTasks(
+      { status: ['completed', 'failed'] },
+      { credentials: mockCredentials.user() },
+    );
+  });
 });