chore: use existing api for starred entities

Signed-off-by: blam <ben@blam.sh>

plugins/catalog-react/api-report.md

@@ -686,7 +686,6 @@ export function MockEntityListContextProvider<
 
 // @public
 export class MockStarredEntitiesApi implements StarredEntitiesApi {
-  constructor(opts?: { starredEntities?: string[] });
   // (undocumented)
   starredEntitie$(): Observable<Set<string>>;
   // (undocumented)

plugins/catalog-react/src/apis/StarredEntitiesApi/MockStarredEntitiesApi.ts

@@ -29,10 +29,6 @@ export class MockStarredEntitiesApi implements StarredEntitiesApi {
     ZenObservable.SubscriptionObserver<Set<string>>
   >();
 
-  constructor(opts: { starredEntities?: string[] } = {}) {
-    this.starredEntities = new Set(opts.starredEntities);
-  }
-
   private readonly observable = new ObservableImpl<Set<string>>(subscriber => {
     subscriber.next(new Set(this.starredEntities));
 

plugins/catalog-react/src/components/FavoriteEntity/FavoriteEntity.test.tsx

@@ -73,16 +73,14 @@ describe('<FavoriteEntity/>', () => {
   });
 
   it('should remove from favorites', async () => {
+    const starredEntities = new MockStarredEntitiesApi();
+    await starredEntities.toggleStarred('component:default/example');
+
     await renderInTestApp(
       <TestApiProvider
         apis={[
           [storageApiRef, mockStorage],
-          [
-            starredEntitiesApiRef,
-            new MockStarredEntitiesApi({
-              starredEntities: ['component:default/example'],
-            }),
-          ],
+          [starredEntitiesApiRef, starredEntities],
         ]}
       >
         <FavoriteEntity entity={entity} />