paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 39 Packages Projects Releases Wiki Activity

refactor(cookieAuth): set cookie domain against discovery base url

Browse Source 
Signed-off-by: Phil Kuang <pkuang@factset.com>
This commit is contained in:
Phil Kuang
2024-04-11 09:00:42 -04:00
parent 2706c3b181
commit 438245968b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/backend-app-api/src/services/implementations/httpAuth/httpAuthServiceFactory.ts
+4 -4
View File
@@ -218,19 +218,19 @@ class DefaultHttpAuthService implements HttpAuthService {
return { expiresAt };
}
async #getCookieOptions(req: Request): Promise<{
async #getCookieOptions(_req: Request): Promise<{
domain: string;
httpOnly: true;
secure: boolean;
priority: 'high';
sameSite: 'none' | 'lax';
}> {
const requestBaseUrl = `${req.protocol}://${req.hostname}`;
// TODO: eventually we should read from `${req.protocol}://${req.hostname}`
// once https://github.com/backstage/backstage/issues/24169 has landed
const externalBaseUrlStr = await this.#discovery.getExternalBaseUrl(
this.#pluginId,
);
const externalBaseUrl = new URL(requestBaseUrl ?? externalBaseUrlStr);
const externalBaseUrl = new URL(externalBaseUrlStr);
const secure =
externalBaseUrl.protocol === 'https:' ||