From 4301cbc5a85efb0187a0459eb207a20ab093ba96 Mon Sep 17 00:00:00 2001 From: Stephen Glass Date: Fri, 23 Aug 2024 00:54:41 -0400 Subject: [PATCH] support minLength and maxLength properties for secret widget Signed-off-by: Stephen Glass --- .changeset/sharp-fans-tan.md | 7 ++++--- .../src/next/components/SecretWidget/SecretWidget.tsx | 6 +++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.changeset/sharp-fans-tan.md b/.changeset/sharp-fans-tan.md index 2ebb24849f..add4a85758 100644 --- a/.changeset/sharp-fans-tan.md +++ b/.changeset/sharp-fans-tan.md @@ -2,6 +2,7 @@ '@backstage/plugin-scaffolder-react': patch --- -- Fix scaffolder secret widget field not displaying as required when it's listed as required. -- Fix scaffolder secret widget not able to be required inside nested objects. -- Fix scaffolder secret widget not able to be disabled. +- Fix secret widget field not displaying as required. +- Fix secret widget not able to be required inside nested objects. +- Fix secret widget not able to be disabled. +- Support `minLength` and `maxLength` properties for secret widget. diff --git a/plugins/scaffolder-react/src/next/components/SecretWidget/SecretWidget.tsx b/plugins/scaffolder-react/src/next/components/SecretWidget/SecretWidget.tsx index 46088aba20..6b9094c199 100644 --- a/plugins/scaffolder-react/src/next/components/SecretWidget/SecretWidget.tsx +++ b/plugins/scaffolder-react/src/next/components/SecretWidget/SecretWidget.tsx @@ -33,7 +33,7 @@ export const SecretWidget = ( const { name, onChange, - schema: { title }, + schema: { title, minLength, maxLength }, required, disabled, } = props; @@ -52,6 +52,10 @@ export const SecretWidget = ( autoComplete="off" required={required} disabled={disabled} + inputProps={{ + minLength, + maxLength, + }} /> ); };