From 42175496486ed1f79bb4f1a0adf5eba4a1f484ef Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Wed, 27 Oct 2021 21:26:32 +0200
Subject: [PATCH] core-app-api: rename PrivateAppImpl to AppManager

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../src/app/{App.test.tsx => AppManager.test.tsx}    | 12 ++++++------
 .../core-app-api/src/app/{App.tsx => AppManager.tsx} |  4 ++--
 packages/core-app-api/src/app/createApp.tsx          |  4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)
 rename packages/core-app-api/src/app/{App.test.tsx => AppManager.test.tsx} (98%)
 rename packages/core-app-api/src/app/{App.tsx => AppManager.tsx} (99%)

diff --git a/packages/core-app-api/src/app/App.test.tsx b/packages/core-app-api/src/app/AppManager.test.tsx
similarity index 98%
rename from packages/core-app-api/src/app/App.test.tsx
rename to packages/core-app-api/src/app/AppManager.test.tsx
index 198048f8cf..934ca3295f 100644
--- a/packages/core-app-api/src/app/App.test.tsx
+++ b/packages/core-app-api/src/app/AppManager.test.tsx
@@ -37,7 +37,7 @@ import {
   createRoutableExtension,
   analyticsApiRef,
 } from '@backstage/core-plugin-api';
-import { generateBoundRoutes, PrivateAppImpl } from './App';
+import { generateBoundRoutes, AppManager } from './AppManager';
 import { AppComponents } from './types';
 
 describe('generateBoundRoutes', () => {
@@ -188,7 +188,7 @@ describe('Integration Test', () => {
   };
 
   it('runs happy paths', async () => {
-    const app = new PrivateAppImpl({
+    const app = new AppManager({
       apis: [noOpAnalyticsApi],
       defaultApis: [],
       themes: [
@@ -242,7 +242,7 @@ describe('Integration Test', () => {
   });
 
   it('runs happy paths without optional routes', async () => {
-    const app = new PrivateAppImpl({
+    const app = new AppManager({
       apis: [noOpAnalyticsApi],
       defaultApis: [],
       themes: [
@@ -299,7 +299,7 @@ describe('Integration Test', () => {
       }),
     ];
 
-    const app = new PrivateAppImpl({
+    const app = new AppManager({
       apis,
       defaultApis: [],
       themes: [
@@ -349,7 +349,7 @@ describe('Integration Test', () => {
   it('should track route changes via analytics api', async () => {
     const mockAnalyticsApi = new MockAnalyticsApi();
     const apis = [createApiFactory(analyticsApiRef, mockAnalyticsApi)];
-    const app = new PrivateAppImpl({
+    const app = new AppManager({
       apis,
       defaultApis: [],
       themes: [
@@ -409,7 +409,7 @@ describe('Integration Test', () => {
   });
 
   it('should throw some error when the route has duplicate params', () => {
-    const app = new PrivateAppImpl({
+    const app = new AppManager({
       apis: [],
       defaultApis: [],
       themes: [
diff --git a/packages/core-app-api/src/app/App.tsx b/packages/core-app-api/src/app/AppManager.tsx
similarity index 99%
rename from packages/core-app-api/src/app/App.tsx
rename to packages/core-app-api/src/app/AppManager.tsx
index 81da370b6c..ff501aa100 100644
--- a/packages/core-app-api/src/app/App.tsx
+++ b/packages/core-app-api/src/app/AppManager.tsx
@@ -171,7 +171,7 @@ function useConfigLoader(
 }
 
 class AppContextImpl implements AppContext {
-  constructor(private readonly app: PrivateAppImpl) {}
+  constructor(private readonly app: AppManager) {}
 
   getPlugins(): BackstagePlugin<any, any>[] {
     return this.app.getPlugins();
@@ -186,7 +186,7 @@ class AppContextImpl implements AppContext {
   }
 }
 
-export class PrivateAppImpl implements BackstageApp {
+export class AppManager implements BackstageApp {
   private apiHolder?: ApiHolder;
   private configApi?: ConfigApi;
 
diff --git a/packages/core-app-api/src/app/createApp.tsx b/packages/core-app-api/src/app/createApp.tsx
index c3f477035f..5bb5607a37 100644
--- a/packages/core-app-api/src/app/createApp.tsx
+++ b/packages/core-app-api/src/app/createApp.tsx
@@ -17,7 +17,7 @@
 import { AppConfig } from '@backstage/config';
 import { JsonObject } from '@backstage/types';
 import { withDefaults } from '@backstage/core-components';
-import { PrivateAppImpl } from './App';
+import { AppManager } from './AppManager';
 import { AppComponents, AppConfigLoader, AppOptions } from './types';
 import { defaultApis } from './defaultApis';
 import { BackstagePlugin } from '@backstage/core-plugin-api';
@@ -132,7 +132,7 @@ export function createApp(options?: AppOptions) {
 
   const { icons, themes, components } = optionsWithDefaults;
 
-  return new PrivateAppImpl({
+  return new AppManager({
     icons: icons!,
     themes: themes!,
     components: components! as AppComponents,