From 40b8a7a280f9361b078a66c9b8b562eeef8a5a0b Mon Sep 17 00:00:00 2001 From: blam Date: Tue, 3 Sep 2024 12:02:17 +0200 Subject: [PATCH] chore: should be wrapped up in a plugin instead of a module Signed-off-by: blam --- .../src/blueprints/SignInPageBlueprint.test.tsx | 1 - packages/frontend-test-utils/src/app/renderInTestApp.tsx | 7 +++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/frontend-plugin-api/src/blueprints/SignInPageBlueprint.test.tsx b/packages/frontend-plugin-api/src/blueprints/SignInPageBlueprint.test.tsx index 2637873930..a85b5e6f39 100644 --- a/packages/frontend-plugin-api/src/blueprints/SignInPageBlueprint.test.tsx +++ b/packages/frontend-plugin-api/src/blueprints/SignInPageBlueprint.test.tsx @@ -57,7 +57,6 @@ describe('SignInPageBlueprint', () => { const MockSignInPage = () =>
; const extension = SignInPageBlueprint.make({ - name: 'test', params: { loader: async () => () => }, }); diff --git a/packages/frontend-test-utils/src/app/renderInTestApp.tsx b/packages/frontend-test-utils/src/app/renderInTestApp.tsx index 80897e942a..e53566a118 100644 --- a/packages/frontend-test-utils/src/app/renderInTestApp.tsx +++ b/packages/frontend-test-utils/src/app/renderInTestApp.tsx @@ -32,7 +32,7 @@ import { IconComponent, RouterBlueprint, NavItemBlueprint, - createExtensionOverrides, + createFrontendPlugin, } from '@backstage/frontend-plugin-api'; import appPlugin from '@backstage/plugin-app'; @@ -136,7 +136,6 @@ export function renderInTestApp( ): RenderResult { const extensions: Array = [ createExtension({ - namespace: 'test', attachTo: { id: 'app/routes', input: 'routes' }, output: [coreExtensionData.reactElement, coreExtensionData.routePath], factory: () => { @@ -147,7 +146,6 @@ export function renderInTestApp( }, }), RouterBlueprint.make({ - namespace: 'test', params: { Component: ({ children }) => {children}, }, @@ -182,7 +180,8 @@ export function renderInTestApp( } const features: FrontendFeature[] = [ - createExtensionOverrides({ + createFrontendPlugin({ + id: 'test', extensions, }), appPluginOverride,