From 7167a05053f7335bccb96f60c68bf7cdf51b2882 Mon Sep 17 00:00:00 2001 From: Timothy Deakin Date: Thu, 28 Mar 2024 23:49:47 +0000 Subject: [PATCH 1/7] refactor: update auth module default export Signed-off-by: Timothy Deakin --- plugins/auth-backend-module-aws-alb-provider/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/auth-backend-module-aws-alb-provider/src/index.ts b/plugins/auth-backend-module-aws-alb-provider/src/index.ts index 779f558f54..9442a5195e 100644 --- a/plugins/auth-backend-module-aws-alb-provider/src/index.ts +++ b/plugins/auth-backend-module-aws-alb-provider/src/index.ts @@ -21,6 +21,6 @@ */ export { awsAlbAuthenticator } from './authenticator'; -export { authModuleAwsAlbProvider } from './module'; +export { authModuleAwsAlbProvider as default } from './module'; export { awsAlbSignInResolvers } from './resolvers'; export { type AwsAlbResult } from './types'; From 30f5a51ed81b7986460f66530b6c17ddc69ee8d4 Mon Sep 17 00:00:00 2001 From: Timothy Deakin Date: Fri, 29 Mar 2024 00:03:25 +0000 Subject: [PATCH 2/7] chore: add changeset Signed-off-by: Timothy Deakin --- .changeset/old-insects-smoke.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/old-insects-smoke.md diff --git a/.changeset/old-insects-smoke.md b/.changeset/old-insects-smoke.md new file mode 100644 index 0000000000..bca298e7d1 --- /dev/null +++ b/.changeset/old-insects-smoke.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-auth-backend-module-aws-alb-provider': minor +--- + +**BREAKING** The `authModuleAwsAlbProvider` is now the default export and should be used like this in your backend: `backend.add(import('@backstage/plugin-auth-backend-module-aws-alb-provider'));` From f2070d54f5880d375a8d84f646b7c37d34cc1add Mon Sep 17 00:00:00 2001 From: Timothy Deakin Date: Fri, 29 Mar 2024 00:22:37 +0000 Subject: [PATCH 3/7] chore: update api report Signed-off-by: Timothy Deakin --- plugins/auth-backend-module-aws-alb-provider/api-report.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/auth-backend-module-aws-alb-provider/api-report.md b/plugins/auth-backend-module-aws-alb-provider/api-report.md index c1f0c6f01b..873001d88e 100644 --- a/plugins/auth-backend-module-aws-alb-provider/api-report.md +++ b/plugins/auth-backend-module-aws-alb-provider/api-report.md @@ -13,7 +13,8 @@ import { ProxyAuthenticator } from '@backstage/plugin-auth-node'; import { SignInResolverFactory } from '@backstage/plugin-auth-node'; // @public (undocumented) -export const authModuleAwsAlbProvider: () => BackendFeature; +const authModuleAwsAlbProvider: () => BackendFeature; +export default authModuleAwsAlbProvider; // @public (undocumented) export const awsAlbAuthenticator: ProxyAuthenticator< From 302b28386248142a40274785f1f43cc36e665f77 Mon Sep 17 00:00:00 2001 From: Timothy Deakin Date: Fri, 29 Mar 2024 13:34:00 +0000 Subject: [PATCH 4/7] chore: update comments Signed-off-by: Timothy Deakin --- plugins/auth-backend-module-aws-alb-provider/README.md | 2 +- plugins/auth-backend-module-aws-alb-provider/src/resolvers.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/auth-backend-module-aws-alb-provider/README.md b/plugins/auth-backend-module-aws-alb-provider/README.md index dd92ae7ba2..1d7b70dbe7 100644 --- a/plugins/auth-backend-module-aws-alb-provider/README.md +++ b/plugins/auth-backend-module-aws-alb-provider/README.md @@ -1,6 +1,6 @@ # Auth Module: AWS ALB Provider -This module provides an GitHub auth provider implementation for `@backstage/plugin-auth-backend`. +This module provides an AWS application load balancer auth provider implementation for `@backstage/plugin-auth-backend`. ## Links diff --git a/plugins/auth-backend-module-aws-alb-provider/src/resolvers.ts b/plugins/auth-backend-module-aws-alb-provider/src/resolvers.ts index 602498ed57..990c447124 100644 --- a/plugins/auth-backend-module-aws-alb-provider/src/resolvers.ts +++ b/plugins/auth-backend-module-aws-alb-provider/src/resolvers.ts @@ -20,7 +20,7 @@ import { } from '@backstage/plugin-auth-node'; import { AwsAlbResult } from './types'; /** - * Available sign-in resolvers for the Google auth provider. + * Available sign-in resolvers for the AWS ALB auth provider. * * @public */ From 340cbdb8af0358c27cb150a6d8aa0af819b7e0fe Mon Sep 17 00:00:00 2001 From: Timothy Deakin Date: Fri, 29 Mar 2024 14:39:11 +0000 Subject: [PATCH 5/7] refactor: maintain backwards compat of export Signed-off-by: Timothy Deakin --- plugins/auth-backend-module-aws-alb-provider/api-report.md | 1 + plugins/auth-backend-module-aws-alb-provider/src/index.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/plugins/auth-backend-module-aws-alb-provider/api-report.md b/plugins/auth-backend-module-aws-alb-provider/api-report.md index 873001d88e..1f95605114 100644 --- a/plugins/auth-backend-module-aws-alb-provider/api-report.md +++ b/plugins/auth-backend-module-aws-alb-provider/api-report.md @@ -14,6 +14,7 @@ import { SignInResolverFactory } from '@backstage/plugin-auth-node'; // @public (undocumented) const authModuleAwsAlbProvider: () => BackendFeature; +export { authModuleAwsAlbProvider }; export default authModuleAwsAlbProvider; // @public (undocumented) diff --git a/plugins/auth-backend-module-aws-alb-provider/src/index.ts b/plugins/auth-backend-module-aws-alb-provider/src/index.ts index 9442a5195e..d5bb259b59 100644 --- a/plugins/auth-backend-module-aws-alb-provider/src/index.ts +++ b/plugins/auth-backend-module-aws-alb-provider/src/index.ts @@ -21,6 +21,7 @@ */ export { awsAlbAuthenticator } from './authenticator'; +export { authModuleAwsAlbProvider } from './module'; export { authModuleAwsAlbProvider as default } from './module'; export { awsAlbSignInResolvers } from './resolvers'; export { type AwsAlbResult } from './types'; From 8d94906605c2e58800071086773f258052b0c645 Mon Sep 17 00:00:00 2001 From: Timothy Deakin Date: Fri, 29 Mar 2024 14:48:14 +0000 Subject: [PATCH 6/7] chore: update changeset Signed-off-by: Timothy Deakin --- .changeset/old-insects-smoke.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.changeset/old-insects-smoke.md b/.changeset/old-insects-smoke.md index bca298e7d1..17ab044c04 100644 --- a/.changeset/old-insects-smoke.md +++ b/.changeset/old-insects-smoke.md @@ -2,4 +2,6 @@ '@backstage/plugin-auth-backend-module-aws-alb-provider': minor --- -**BREAKING** The `authModuleAwsAlbProvider` is now the default export and should be used like this in your backend: `backend.add(import('@backstage/plugin-auth-backend-module-aws-alb-provider'));` +Added `authModuleAwsAlbProvider` as a default export. + +It can now be used like this in your backend: `backend.add(import('@backstage/plugin-auth-backend-module-aws-alb-provider'));` From 4f1ede38fbbfa621017aa013d3012873e15637f9 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Wed, 3 Apr 2024 17:56:32 +0200 Subject: [PATCH 7/7] Update .changeset/old-insects-smoke.md Signed-off-by: Patrik Oldsberg --- .changeset/old-insects-smoke.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/old-insects-smoke.md b/.changeset/old-insects-smoke.md index 17ab044c04..78c6e7d728 100644 --- a/.changeset/old-insects-smoke.md +++ b/.changeset/old-insects-smoke.md @@ -1,5 +1,5 @@ --- -'@backstage/plugin-auth-backend-module-aws-alb-provider': minor +'@backstage/plugin-auth-backend-module-aws-alb-provider': patch --- Added `authModuleAwsAlbProvider` as a default export.