more api cleanup

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

plugins/search-backend-node/api-report.md

@@ -56,9 +56,9 @@ export abstract class DecoratorBase extends Transform {
 
 // @public
 export class IndexBuilder {
-  constructor({ logger, searchEngine }: IndexBuilderOptions);
-  addCollator({ factory, schedule }: RegisterCollatorParameters): void;
-  addDecorator({ factory }: RegisterDecoratorParameters): void;
+  constructor(options: IndexBuilderOptions);
+  addCollator(options: RegisterCollatorParameters): void;
+  addDecorator(options: RegisterDecoratorParameters): void;
   build(): Promise<{
     scheduler: Scheduler;
   }>;
@@ -77,7 +77,7 @@ export type LunrQueryTranslator = (query: SearchQuery) => ConcreteLunrQuery;
 
 // @public
 export class LunrSearchEngine implements SearchEngine {
-  constructor({ logger }: { logger: Logger });
+  constructor(options: { logger: Logger });
   // (undocumented)
   protected docStore: Record<string, IndexableDocument>;
   // (undocumented)
@@ -157,8 +157,8 @@ export interface RegisterDecoratorParameters {
 
 // @public
 export class Scheduler {
-  constructor({ logger }: { logger: Logger });
-  addToSchedule({ id, task, scheduledRunner }: ScheduleTaskParameters): void;
+  constructor(options: { logger: Logger });
+  addToSchedule(options: ScheduleTaskParameters): void;
   start(): void;
   stop(): void;
 }

plugins/search-backend-node/src/IndexBuilder.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import {
   DocumentDecoratorFactory,
   DocumentTypeInfo,
@@ -38,12 +39,12 @@ export class IndexBuilder {
   private searchEngine: SearchEngine;
   private logger: Logger;
 
-  constructor({ logger, searchEngine }: IndexBuilderOptions) {
+  constructor(options: IndexBuilderOptions) {
     this.collators = {};
     this.decorators = {};
     this.documentTypes = {};
-    this.logger = logger;
-    this.searchEngine = searchEngine;
+    this.logger = options.logger;
+    this.searchEngine = options.searchEngine;
   }
 
   /**
@@ -64,7 +65,9 @@ export class IndexBuilder {
    * Makes the index builder aware of a collator that should be executed at the
    * given refresh interval.
    */
-  addCollator({ factory, schedule }: RegisterCollatorParameters): void {
+  addCollator(options: RegisterCollatorParameters): void {
+    const { factory, schedule } = options;
+
     this.logger.info(
       `Added ${factory.constructor.name} collator factory for type ${factory.type}`,
     );
@@ -82,7 +85,8 @@ export class IndexBuilder {
    * the decorator, it will be applied to documents from all known collators,
    * otherwise it will only be applied to documents of the given types.
    */
-  addDecorator({ factory }: RegisterDecoratorParameters): void {
+  addDecorator(options: RegisterDecoratorParameters): void {
+    const { factory } = options;
     const types = factory.types || ['*'];
     this.logger.info(
       `Added decorator ${factory.constructor.name} to types ${types.join(

plugins/search-backend-node/src/Scheduler.ts

@@ -43,8 +43,8 @@ export class Scheduler {
   private abortController: AbortController;
   private isRunning: boolean;
 
-  constructor({ logger }: { logger: Logger }) {
-    this.logger = logger;
+  constructor(options: { logger: Logger }) {
+    this.logger = options.logger;
     this.schedule = {};
     this.abortController = new AbortController();
     this.isRunning = false;
@@ -55,7 +55,9 @@ export class Scheduler {
    * When running the tasks, the scheduler waits at least for the time specified
    * in the interval once the task was completed, before running it again.
    */
-  addToSchedule({ id, task, scheduledRunner }: ScheduleTaskParameters) {
+  addToSchedule(options: ScheduleTaskParameters) {
+    const { id, task, scheduledRunner } = options;
+
     if (this.isRunning) {
       throw new Error(
         'Cannot add task to schedule that has already been started.',

plugins/search-backend-node/src/engines/LunrSearchEngine.ts

@@ -43,7 +43,7 @@ type LunrResultEnvelope = {
 };
 
 /**
- * Translator repsonsible for translating search term and filters to a query that the Lunr Search Engine understands.
+ * Translator responsible for translating search term and filters to a query that the Lunr Search Engine understands.
  * @public
  */
 export type LunrQueryTranslator = (query: SearchQuery) => ConcreteLunrQuery;
@@ -59,8 +59,8 @@ export class LunrSearchEngine implements SearchEngine {
   protected highlightPreTag: string;
   protected highlightPostTag: string;
 
-  constructor({ logger }: { logger: Logger }) {
-    this.logger = logger;
+  constructor(options: { logger: Logger }) {
+    this.logger = options.logger;
     this.docStore = {};
     const uuidTag = uuid();
     this.highlightPreTag = `<${uuidTag}>`;