From 3f447ec3e12dd10e3763d228597c2accb1cb2837 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= <freben@gmail.com>
Date: Sat, 6 Nov 2021 09:58:15 +0100
Subject: [PATCH] use lodash.once instead of memoize, and skip unnecessary PK
 index
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
---
 packages/backend-tasks/migrations/20210928160613_init.js | 4 ----
 packages/backend-tasks/src/tasks/TaskScheduler.ts        | 4 ++--
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/packages/backend-tasks/migrations/20210928160613_init.js b/packages/backend-tasks/migrations/20210928160613_init.js
index cd812b59e8..21d80ae24c 100644
--- a/packages/backend-tasks/migrations/20210928160613_init.js
+++ b/packages/backend-tasks/migrations/20210928160613_init.js
@@ -50,7 +50,6 @@ exports.up = async function up(knex) {
       .dateTime('current_run_expires_at')
       .nullable()
       .comment('The time that the current task run will time out');
-    table.index(['id'], 'backstage_backend_tasks__tasks__id_idx');
   });
 };
 
@@ -61,8 +60,5 @@ exports.down = async function down(knex) {
   //
   // tasks
   //
-  await knex.schema.alterTable('backstage_backend_tasks__tasks', table => {
-    table.dropIndex([], 'backstage_backend_tasks__tasks__id_idx');
-  });
   await knex.schema.dropTable('backstage_backend_tasks__tasks');
 };
diff --git a/packages/backend-tasks/src/tasks/TaskScheduler.ts b/packages/backend-tasks/src/tasks/TaskScheduler.ts
index b24338e5c6..f1668a6691 100644
--- a/packages/backend-tasks/src/tasks/TaskScheduler.ts
+++ b/packages/backend-tasks/src/tasks/TaskScheduler.ts
@@ -16,7 +16,7 @@
 
 import { DatabaseManager, getRootLogger } from '@backstage/backend-common';
 import { Config } from '@backstage/config';
-import { memoize } from 'lodash';
+import { once } from 'lodash';
 import { Duration } from 'luxon';
 import { Logger } from 'winston';
 import { migrateBackendTasks } from '../database/migrateBackendTasks';
@@ -57,7 +57,7 @@ export class TaskScheduler {
    * @returns A {@link PluginTaskScheduler} instance
    */
   forPlugin(pluginId: string): PluginTaskScheduler {
-    const databaseFactory = memoize(async () => {
+    const databaseFactory = once(async () => {
       const knex = await this.databaseManager.forPlugin(pluginId).getClient();
 
       await migrateBackendTasks(knex);