paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

scaffolder-backend: more reliable error matching in SecureTemplater tests

Browse Source 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
Patrik Oldsberg
2021-11-24 22:20:30 +01:00
parent f514044f8d
commit 3f320fb922
1 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/scaffolder-backend/src/lib/templating/SecureTemplater.test.ts
+8 -12
View File
@@ -35,9 +35,7 @@ describe('SecureTemplater', () => {
render('${{ invalid...syntax }}', {
test: 'my-value',
}),
).toThrow(
'(unknown path) [Line 1, Column 13]\n expected name as lookup value, got .',
);
).toThrow(/expected name as lookup value, got ./);
});
it('should make cookiecutter compatibility available when requested', async () => {
@@ -50,17 +48,17 @@ describe('SecureTemplater', () => {
expect(renderWith('{{ 1 | jsonify }}', {})).toBe('1');
expect(renderWith('{{ 1 | jsonify }}', {})).toBe('1');
expect(() => renderWithout('${{ 1 | jsonify }}', {})).toThrow(
'(unknown path)\n Error: filter not found: jsonify',
/Error: filter not found: jsonify/,
);
expect(renderWith('{{ 1 | jsonify }}', {})).toBe('1');
expect(() => renderWithout('${{ 1 | jsonify }}', {})).toThrow(
'(unknown path)\n Error: filter not found: jsonify',
/Error: filter not found: jsonify/,
);
expect(() => renderWithout('${{ 1 | jsonify }}', {})).toThrow(
'(unknown path)\n Error: filter not found: jsonify',
/Error: filter not found: jsonify/,
);
expect(() => renderWithout('${{ 1 | jsonify }}', {})).toThrow(
'(unknown path)\n Error: filter not found: jsonify',
/Error: filter not found: jsonify/,
);
expect(renderWith('{{ 1 | jsonify }}', {})).toBe('1');
});
@@ -90,9 +88,9 @@ describe('SecureTemplater', () => {
);
expect(() =>
renderWithout('${{ repoUrl | parseRepoUrl | dump }}', ctx),
).toThrow('(unknown path)\n Error: filter not found: parseRepoUrl');
).toThrow(/Error: filter not found: parseRepoUrl/);
expect(() => renderWithout('${{ repoUrl | projectSlug }}', ctx)).toThrow(
'(unknown path)\n Error: filter not found: projectSlug',
/Error: filter not found: projectSlug/,
);
expect(parseRepoUrl.mock.calls).toEqual([
@@ -142,8 +140,6 @@ describe('SecureTemplater', () => {
ctx,
),
).toBe('');
expect(() => render('${{ x }}', ctx)).toThrow(
`TypeError: Cannot read property 'length' of undefined`,
);
expect(() => render('${{ x }}', ctx)).toThrow();
});
});