From 3ec99fbc55119810861c9861789d6713709c3603 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Mon, 7 Sep 2020 17:30:57 +0200
Subject: [PATCH] cli: make skipLibCheck default in tsconfig, but provide
 tsc:full

---
 .github/workflows/ci.yml                                   | 2 +-
 .github/workflows/master-win.yml                           | 2 +-
 .github/workflows/master.yml                               | 2 +-
 docs/getting-started/development-environment.md            | 1 +
 package.json                                               | 1 +
 packages/cli/config/tsconfig.json                          | 1 +
 packages/create-app/templates/default-app/package.json.hbs | 1 +
 packages/create-app/templates/default-app/tsconfig.json    | 3 +--
 8 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2246a1dc09..0a094a10b3 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -76,7 +76,7 @@ jobs:
         run: yarn lerna -- run lint --since origin/master
 
       - name: type checking and declarations
-        run: yarn tsc --incremental false
+        run: yarn tsc:full
 
       - name: build changed packages
         if: ${{ steps.yarn-lock.outcome == 'success' }}
diff --git a/.github/workflows/master-win.yml b/.github/workflows/master-win.yml
index 5951721f68..3f65cf9aec 100644
--- a/.github/workflows/master-win.yml
+++ b/.github/workflows/master-win.yml
@@ -43,7 +43,7 @@ jobs:
         run: yarn lerna -- run lint
 
       - name: type checking and declarations
-        run: yarn tsc --incremental false
+        run: yarn tsc:full
 
       - name: verify type dependencies
         run: yarn lint:type-deps
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
index b5c4fdf370..469ef20cda 100644
--- a/.github/workflows/master.yml
+++ b/.github/workflows/master.yml
@@ -51,7 +51,7 @@ jobs:
         run: yarn lerna -- run lint
 
       - name: type checking and declarations
-        run: yarn tsc --incremental false
+        run: yarn tsc:full
 
       - name: build
         run: yarn build
diff --git a/docs/getting-started/development-environment.md b/docs/getting-started/development-environment.md
index 421ce6d2c5..9c75c8eabf 100644
--- a/docs/getting-started/development-environment.md
+++ b/docs/getting-started/development-environment.md
@@ -65,6 +65,7 @@ yarn storybook # Start local storybook, useful for working on components in @bac
 yarn workspace @backstage/plugin-welcome start # Serve welcome plugin only, also supports --check
 
 yarn tsc # Run typecheck, use --watch for watch mode
+yarn tsc:full # Run full type checking, for example without skipLibCheck, use in CI
 
 yarn build # Build published versions of packages, depends on tsc
 
diff --git a/package.json b/package.json
index 93f8f694a6..c64b7f6951 100644
--- a/package.json
+++ b/package.json
@@ -10,6 +10,7 @@
     "start-backend": "yarn workspace example-backend start",
     "build": "lerna run build",
     "tsc": "tsc",
+    "tsc:full": "tsc --skipLibCheck false --incremental false",
     "clean": "backstage-cli clean && lerna run clean",
     "diff": "lerna run diff --",
     "test": "lerna run test --since origin/master -- --coverage",
diff --git a/packages/cli/config/tsconfig.json b/packages/cli/config/tsconfig.json
index ce031bc5e7..ef1a8df353 100644
--- a/packages/cli/config/tsconfig.json
+++ b/packages/cli/config/tsconfig.json
@@ -25,6 +25,7 @@
     "removeComments": false,
     "resolveJsonModule": true,
     "sourceMap": false,
+    "skipLibCheck": true,
     "strict": true,
     "strictBindCallApply": true,
     "strictFunctionTypes": true,
diff --git a/packages/create-app/templates/default-app/package.json.hbs b/packages/create-app/templates/default-app/package.json.hbs
index af4384318a..b95b5bbc5b 100644
--- a/packages/create-app/templates/default-app/package.json.hbs
+++ b/packages/create-app/templates/default-app/package.json.hbs
@@ -9,6 +9,7 @@
     "start": "yarn workspace app start",
     "build": "lerna run build",
     "tsc": "tsc",
+    "tsc:full": "tsc --skipLibCheck false --incremental false",
     "clean": "backstage-cli clean && lerna run clean",
     "diff": "lerna run diff --",
     "test": "lerna run test --since origin/master -- --coverage",
diff --git a/packages/create-app/templates/default-app/tsconfig.json b/packages/create-app/templates/default-app/tsconfig.json
index b1ec99b986..ba3f90177d 100644
--- a/packages/create-app/templates/default-app/tsconfig.json
+++ b/packages/create-app/templates/default-app/tsconfig.json
@@ -9,7 +9,6 @@
   "exclude": ["node_modules"],
   "compilerOptions": {
     "outDir": "dist-types",
-    "rootDir": ".",
-    "skipLibCheck": true
+    "rootDir": "."
   }
 }