From 0f93b6707e0418b8a43d1c084756113f037d8c9e Mon Sep 17 00:00:00 2001 From: David Weber Date: Wed, 17 May 2023 21:54:21 +0200 Subject: [PATCH] fix: don't expose sensible data Signed-off-by: David Weber --- .changeset/clean-meals-pay.md | 5 +++++ plugins/jenkins-backend/config.d.ts | 8 +++++++- 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 .changeset/clean-meals-pay.md diff --git a/.changeset/clean-meals-pay.md b/.changeset/clean-meals-pay.md new file mode 100644 index 0000000000..629549112c --- /dev/null +++ b/.changeset/clean-meals-pay.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-jenkins-backend': patch +--- + +Don't expose username and authentication header if configured. diff --git a/plugins/jenkins-backend/config.d.ts b/plugins/jenkins-backend/config.d.ts index 3dda0a73c5..5b725dd801 100644 --- a/plugins/jenkins-backend/config.d.ts +++ b/plugins/jenkins-backend/config.d.ts @@ -38,11 +38,17 @@ export interface Config { * instance. */ name: string; - baseUrl: string; username: string; /** @visibility secret */ apiKey: string; + extraRequestHeaders?: Partial<{ + /** @visibility secret */ + Authorization: string; + /** @visibility secret */ + authorization: string; + [key: string]: string; + }>; }[]; }; }